Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change flag from supress_generation_errors to raise_generation_errors #2468

Closed
wants to merge 1 commit into from

Conversation

mgarrard
Copy link
Contributor

Summary: Cleans up an easy todo that adds additional clarity to one of the generation node methods where we make raising an error the exception as opposed to the expectation

Differential Revision: D57477070

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57477070

…facebook#2468)

Summary:

Cleans up an easy todo that adds additional clarity to one of the generation node methods where we make raising an error the exception as opposed to the expectation

Differential Revision: D57477070
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57477070

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.26%. Comparing base (d97a80e) to head (cde454d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2468   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files         485      485           
  Lines       47393    47393           
=======================================
  Hits        45147    45147           
  Misses       2246     2246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 6558d27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants