Adding copyright comment to "test_transform_encode" #2445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57163822 |
Summary: ``` Every project specific source file must contain a doc block with an appropriate copyright header. Unrelated files must be listed as exceptions in the Copyright Headers Exceptions page in the repo dashboard. A copyright header clearly indicates that the code is owned by Meta. Every open source file must start with a comment containing "Meta Platforms, Inc. and affiliates" https://github.com/facebook/Ax/blob/main/ax/storage/json_store/tests/test_transform_encode.py: The first 16 lines of 'ax/storage/json_store/tests/test_transform_encode.py' do not contain the patterns: Copyright ``` Adding the copyright doc block to the offending file. Differential Revision: D57163822
mgrange1998
force-pushed
the
export-D57163822
branch
from
204e844
to
ef1d18a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57163822 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2445 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 497 497
Lines 48194 48194
=======================================
Hits 45938 45938
Misses 2256 2256 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 2615e15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding the copyright doc block to the offending file.
Differential Revision: D57163822