Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating preference testing stub #2443

Closed
wants to merge 1 commit into from

Conversation

ItsMrLin
Copy link
Contributor

@ItsMrLin ItsMrLin commented May 9, 2024

Summary: Adding preference_stubs.py and migrate PairwiseModelBridgeTest logic to it.

Differential Revision: D57131012

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 9, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57131012

ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request May 9, 2024
Summary:

Adding `preference_stubs.py` and migrate `PairwiseModelBridgeTest` logic to it.

Differential Revision: D57131012
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.31%. Comparing base (231d45d) to head (938fdb8).

Files Patch % Lines
ax/utils/testing/preference_stubs.py 96.49% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2443      +/-   ##
==========================================
- Coverage   95.32%   95.31%   -0.01%     
==========================================
  Files         496      497       +1     
  Lines       48323    48341      +18     
==========================================
+ Hits        46062    46078      +16     
- Misses       2261     2263       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57131012

ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request May 9, 2024
Summary:

Adding `preference_stubs.py` and migrate `PairwiseModelBridgeTest` logic to it.

Reviewed By: esantorella

Differential Revision: D57131012
ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request May 14, 2024
Summary:

Adding `preference_stubs.py` and migrate `PairwiseModelBridgeTest` logic to it.

Reviewed By: esantorella

Differential Revision: D57131012
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57131012

ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request May 14, 2024
Summary:

Adding `preference_stubs.py` and migrate `PairwiseModelBridgeTest` logic to it.

Reviewed By: esantorella

Differential Revision: D57131012
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57131012

Summary:

Adding `preference_stubs.py` and migrate `PairwiseModelBridgeTest` logic to it.

Reviewed By: esantorella

Differential Revision: D57131012
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57131012

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 85b1d6c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants