Use name of enum instead of casting to string #2423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
bernardbeckerman
force-pushed
the
export-D56850035
branch
from
9be2d28
to
56e8898
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56850035 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 494 494
Lines 47920 47930 +10
=======================================
+ Hits 45670 45680 +10
Misses 2250 2250 ☔ View full report in Codecov by Sentry. |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
Summary: `Keys.PAIRWISE_PREFERENCE_QUERY` or `str(Keys.PAIRWISE_PREFERENCE_QUERY)` is commonly used when a string is expected, whereas I'm suspecting the intention is `Keys.PAIRWISE_PREFERENCE_QUERY.name`. This is causing issues in D56634321 which (for now) fails if any metrics in Data.df are not present on experiment when calling observations_from_dataframe. Differential Revision: D56850035
bernardbeckerman
force-pushed
the
export-D56850035
branch
from
56e8898
to
b8f41ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56850035 |
…sponding experiments (facebook#2422) Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue. Reviewed By: saitcakmak Differential Revision: D56850033
Summary: `Keys.PAIRWISE_PREFERENCE_QUERY` or `str(Keys.PAIRWISE_PREFERENCE_QUERY)` is commonly used when a string is expected, whereas I'm suspecting the intention is `Keys.PAIRWISE_PREFERENCE_QUERY.name`. This is causing issues in D56634321 which (for now) fails if any metrics in Data.df are not present on experiment when calling observations_from_dataframe. Differential Revision: D56850035
bernardbeckerman
force-pushed
the
export-D56850035
branch
from
b8f41ca
to
ea3f21d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56850035 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
Summary: `Keys.PAIRWISE_PREFERENCE_QUERY` or `str(Keys.PAIRWISE_PREFERENCE_QUERY)` is commonly used when a string is expected, whereas I'm suspecting the intention is `Keys.PAIRWISE_PREFERENCE_QUERY.name`. This is causing issues in D56634321 which (for now) fails if any metrics in Data.df are not present on experiment when calling observations_from_dataframe. Differential Revision: D56850035
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
Summary: `Keys.PAIRWISE_PREFERENCE_QUERY` or `str(Keys.PAIRWISE_PREFERENCE_QUERY)` is commonly used when a string is expected, whereas I'm suspecting the intention is `Keys.PAIRWISE_PREFERENCE_QUERY.value`. This is causing issues in D56634321 which (for now) fails if any metrics in Data.df are not present on experiment when calling observations_from_dataframe. Reviewed By: Balandat Differential Revision: D56850035
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
Summary: `Keys.PAIRWISE_PREFERENCE_QUERY` or `str(Keys.PAIRWISE_PREFERENCE_QUERY)` is commonly used when a string is expected, whereas I'm suspecting the intention is `Keys.PAIRWISE_PREFERENCE_QUERY.value`. This is causing issues in D56634321 which (for now) fails if any metrics in Data.df are not present on experiment when calling observations_from_dataframe. Reviewed By: Balandat Differential Revision: D56850035
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
Summary: `Keys.PAIRWISE_PREFERENCE_QUERY` or `str(Keys.PAIRWISE_PREFERENCE_QUERY)` is commonly used when a string is expected, whereas I'm suspecting the intention is `Keys.PAIRWISE_PREFERENCE_QUERY.value`. This is causing issues in D56634321 which (for now) fails if any metrics in Data.df are not present on experiment when calling observations_from_dataframe. Reviewed By: Balandat Differential Revision: D56850035
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 7, 2024
Summary: `Keys.PAIRWISE_PREFERENCE_QUERY` or `str(Keys.PAIRWISE_PREFERENCE_QUERY)` is commonly used when a string is expected, whereas I'm suspecting the intention is `Keys.PAIRWISE_PREFERENCE_QUERY.value`. This is causing issues in D56634321 which (for now) fails if any metrics in Data.df are not present on experiment when calling observations_from_dataframe. Reviewed By: Balandat Differential Revision: D56850035
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 7, 2024
Summary: `Keys.PAIRWISE_PREFERENCE_QUERY` or `str(Keys.PAIRWISE_PREFERENCE_QUERY)` is commonly used when a string is expected, whereas I'm suspecting the intention is `Keys.PAIRWISE_PREFERENCE_QUERY.value`. This is causing issues in D56634321 which (for now) fails if any metrics in Data.df are not present on experiment when calling observations_from_dataframe. Reviewed By: Balandat Differential Revision: D56850035
|
This pull request has been merged in f718253. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Keys.PAIRWISE_PREFERENCE_QUERYorstr(Keys.PAIRWISE_PREFERENCE_QUERY)is commonly used when a string is expected, whereas I'm suspecting the intention isKeys.PAIRWISE_PREFERENCE_QUERY.name. This is causing issues in D56634321 which (for now) fails if any metrics in Data.df are not present on experiment when calling observations_from_dataframe.Differential Revision: D56850035