HSS: only check for dependents if the root parameter is present when casting parameterization #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56084081 |
…casting parameterization (facebook#2361) Summary: When `check_all_parameters_present=True`, we error out if any parameter is missing. When it is False, we need to tolerate any missing parameters and ignore that branch of the HSS tree -- not doing so would be ignoring the argument. The previous implementation would error out while trying to look up the value of the missing parameter if it had dependents. Reviewed By: Balandat Differential Revision: D56084081
saitcakmak
force-pushed
the
export-D56084081
branch
from
1e32a59
to
9e0c66d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56084081 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 13, 2024
…casting parameterization (facebook#2361) Summary: When `check_all_parameters_present=True`, we error out if any parameter is missing. When it is False, we need to tolerate any missing parameters and ignore that branch of the HSS tree -- not doing so would be ignoring the argument. The previous implementation would error out while trying to look up the value of the missing parameter if it had dependents. Reviewed By: Balandat Differential Revision: D56084081
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 13, 2024
…casting parameterization (facebook#2361) Summary: When `check_all_parameters_present=True`, we error out if any parameter is missing. When it is False, we need to tolerate any missing parameters and ignore that branch of the HSS tree -- not doing so would be ignoring the argument. The previous implementation would error out while trying to look up the value of the missing parameter if it had dependents. Reviewed By: Balandat Differential Revision: D56084081
|
This pull request has been merged in 97d2a3a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When
check_all_parameters_present=True, we error out if any parameter is missing. When it is False, we need to tolerate any missing parameters and ignore that branch of the HSS tree -- not doing so would be ignoring the argument. The previous implementation would error out while trying to look up the value of the missing parameter if it had dependents.Reviewed By: Balandat
Differential Revision: D56084081