Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch legacy LCE-A to qLogNEI from legacy ei_or_nei #2352

Closed

Commits on Apr 15, 2024

  1. Switch legacy LCE-A to qLogNEI from legacy ei_or_nei (facebook#2352)

    Summary:
    
    Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of `GenerationStrategy`, which these classes hack around, so there's substantial maintenance burden to keeping them.
    
    Context for this diff: LCE-A was depending on ALEBO for, it seems, no reason other than convenience of where the acquisition function constructor lived. This diff aims to address.
    
    **[RfC] But also this made me wonder: maybe better to replace use of `ei_or_nei` in LCE-A with something newer?**
    
    Reviewed By: saitcakmak
    
    Differential Revision: D56037477
    Lena Kashtelyan authored and facebook-github-bot committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    ec91fda View commit details
    Browse the repository at this point in the history