update run_metadata in BaseTrial.run instead of overwriting #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55767138 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2328 +/- ##
=======================================
Coverage 94.91% 94.91%
=======================================
Files 491 491
Lines 47782 47787 +5
=======================================
+ Hits 45350 45355 +5
Misses 2432 2432 ☔ View full report in Codecov by Sentry. |
…#2328) Summary: see title. This enables storing metadata from multiple runners. Reviewed By: Balandat Differential Revision: D55767138
sdaulton
force-pushed
the
export-D55767138
branch
from
2ed2da1
to
1b11390
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55767138 |
|
This pull request has been merged in 484ff7c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: see title. This enables storing metadata from multiple runners.
Reviewed By: Balandat
Differential Revision: D55767138