Typing improvements to RangeParameter
#2327
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55805080 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Apr 12, 2024
Summary: This commit improves the typing coverage for `RangeParameter` and its downstream applications, as well as getters and setters four its bounds that include bounds validation. Reviewed By: bernardbeckerman Differential Revision: D55805080
SebastianAment
force-pushed
the
export-D55805080
branch
from
78a10f6
to
be3a425
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55805080 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Apr 12, 2024
Summary: This commit improves the typing coverage for `RangeParameter` and its downstream applications, as well as getters and setters four its bounds that include bounds validation. Reviewed By: bernardbeckerman Differential Revision: D55805080
SebastianAment
force-pushed
the
export-D55805080
branch
from
be3a425
to
7534e8b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55805080 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Apr 12, 2024
Summary: This commit improves the typing coverage for `RangeParameter` and its downstream applications, as well as getters and setters four its bounds that include bounds validation. Reviewed By: bernardbeckerman Differential Revision: D55805080
SebastianAment
force-pushed
the
export-D55805080
branch
from
7534e8b
to
6cab696
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55805080 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Apr 12, 2024
Summary: This commit improves the typing coverage for `RangeParameter` and its downstream applications, as well as getters and setters four its bounds that include bounds validation. Reviewed By: bernardbeckerman Differential Revision: D55805080
SebastianAment
force-pushed
the
export-D55805080
branch
from
6cab696
to
22d132e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55805080 |
SebastianAment
force-pushed
the
export-D55805080
branch
from
22d132e
to
89d5c65
Compare
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Apr 12, 2024
Summary: This commit improves the typing coverage for `RangeParameter` and its downstream applications, as well as getters and setters four its bounds that include bounds validation. Reviewed By: bernardbeckerman Differential Revision: D55805080
|
This pull request was exported from Phabricator. Differential Revision: D55805080 |
SebastianAment
added a commit
to SebastianAment/Ax
that referenced
this pull request
Apr 12, 2024
Summary: This commit improves the typing coverage for `RangeParameter` and its downstream applications, as well as getters and setters four its bounds that include bounds validation. Reviewed By: bernardbeckerman Differential Revision: D55805080
SebastianAment
force-pushed
the
export-D55805080
branch
from
89d5c65
to
e3736fc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55805080 |
Summary: This commit improves the typing coverage for `RangeParameter` and its downstream applications, as well as getters and setters four its bounds that include bounds validation. Reviewed By: bernardbeckerman Differential Revision: D55805080
SebastianAment
force-pushed
the
export-D55805080
branch
from
e3736fc
to
4403b61
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55805080 |
|
This pull request has been merged in cc2a7ad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This commit improves the typing coverage for
RangeParameterand its downstream applications, as well as getters and setters four its bounds that include bounds validation.Differential Revision: D55805080