Properly handle generators in Data.from_multiple #2318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Since it previously looped through the input twice, it would consume the generator in the first pass and return empty data. Reviewed By: Balandat Differential Revision: D55723466
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55723466 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2318 +/- ##
==========================================
+ Coverage 94.90% 94.91% +0.01%
==========================================
Files 489 489
Lines 47758 47786 +28
==========================================
+ Hits 45324 45356 +32
+ Misses 2434 2430 -4 ☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 4, 2024
Summary: Since it previously looped through the input twice, it would consume the generator in the first pass and return empty data. Reviewed By: Balandat Differential Revision: D55723466
|
This pull request has been merged in 1b29a78. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Since it previously looped through the input twice, it would consume the generator in the first pass and return empty data.
Reviewed By: Balandat
Differential Revision: D55723466