Fix test_sqa_storage_map_metric_experiment #2297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: lena-kashtelyan could I get your help debugging this? This test is currently flaky on prod with errors like "8 is not greater than 10" etc -- are we really sure we should get twice as many calls than there are trials? Reviewed By: lena-kashtelyan Differential Revision: D55254148
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55254148 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 489 489
Lines 47656 47656
=======================================
Hits 45229 45229
Misses 2427 2427 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in d120362. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: lena-kashtelyan could I get your help debugging this? This test is currently flaky on prod with errors like "8 is not greater than 10" etc -- are we really sure we should get twice as many calls than there are trials?
Reviewed By: lena-kashtelyan
Differential Revision: D55254148