Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration test #2282

Closed
wants to merge 1 commit into from
Closed

Fix integration test #2282

wants to merge 1 commit into from

Commits on Mar 18, 2024

  1. Fix integration test (facebook#2282) 

    Summary:

X-link: facebookresearch/aepsych#338

Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node. 

This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py.

We also re-enable the test

Reviewed By: crasanders

Differential Revision: D54960088
    @mgarrard @facebook-github-bot
    mgarrard authored and facebook-github-bot committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    95df2c0 View commit details
    Browse the repository at this point in the history