split common target into native/non-native parts #2280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54861556 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 481 482 +1
Lines 47052 47059 +7
=======================================
+ Hits 44653 44660 +7
Misses 2399 2399 ☔ View full report in Codecov by Sentry. |
Summary: This removes pandas, numpy, and several other packages as a deps from several targets Reviewed By: Balandat Differential Revision: D54861556
sdaulton
force-pushed
the
export-D54861556
branch
from
4ef82e9
to
1f04c2b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54861556 |
|
This pull request has been merged in 4f33bea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This removes pandas, numpy, and several other packages as a deps from several targets
Reviewed By: Balandat
Differential Revision: D54861556