Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sobol benchmark method #2257

Closed
wants to merge 1 commit into from

Conversation

saitcakmak
Copy link
Contributor

Summary: This makes it easier to add Sobol into the mix when running benchmarks.

Reviewed By: esantorella

Differential Revision: D54647122

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 7, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54647122

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.85%. Comparing base (e4d632a) to head (63f500b).

❗ Current head 63f500b differs from pull request most recent head c02cdbd. Consider uploading reports for the commit c02cdbd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
- Coverage   94.86%   94.85%   -0.01%     
==========================================
  Files         467      468       +1     
  Lines       46481    46496      +15     
==========================================
+ Hits        44093    44105      +12     
- Misses       2388     2391       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Summary:

This makes it easier to add Sobol into the mix when running benchmarks.

Reviewed By: esantorella

Differential Revision: D54647122
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54647122

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b7e0312.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants