Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust BenchmarkProblem to support multiple noise levels #2049

Closed
wants to merge 1 commit into from

Conversation

Balandat
Copy link
Contributor

@Balandat Balandat commented Dec 6, 2023

Summary: Supports the changes to BoTorch's BaseTestProblem from pytorch/botorch#2136 that allow for multiple noise levels for different outcomes.

Reviewed By: sdaulton

Differential Revision: D51839441

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51839441

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c14ff08) 94.53% compared to head (6e5dd6e) 94.52%.

❗ Current head 6e5dd6e differs from pull request most recent head 94bac90. Consider uploading reports for the commit 94bac90 to get more accurate results

Files Patch % Lines
ax/benchmark/benchmark_problem.py 81.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2049      +/-   ##
==========================================
- Coverage   94.53%   94.52%   -0.01%     
==========================================
  Files         460      460              
  Lines       44554    44570      +16     
==========================================
+ Hits        42118    42131      +13     
- Misses       2436     2439       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…2049)

Summary:

Supports the changes to BoTorch's `BaseTestProblem` from pytorch/botorch#2136 that allow for multiple noise levels for different outcomes.

Reviewed By: sdaulton

Differential Revision: D51839441
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51839441

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in cc32a49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants