move feasibility column leftward for easy reading #2047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51866456 |
|
This pull request was exported from Phabricator. Differential Revision: D51866456 |
Summary: is_feasible is a useful summary column that should come before metric values (esp useful when there are many metrics on the experiment) Reviewed By: zcohn Differential Revision: D51866456
bernardbeckerman
force-pushed
the
export-D51866456
branch
from
f73562f
to
a4878eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51866456 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2047 +/- ##
==========================================
- Coverage 94.52% 94.51% -0.02%
==========================================
Files 460 460
Lines 44522 44496 -26
==========================================
- Hits 42086 42054 -32
- Misses 2436 2442 +6 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 71f6e6e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: is_feasible is a useful summary column that should come before metric values (esp useful when there are many metrics on the experiment)
Reviewed By: zcohn
Differential Revision: D51866456