Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inspect to support typeguard version being overridden #2044

Closed

Conversation

danielcohenlive
Copy link

Summary: Attempt to solve/mitigate #2043

Differential Revision: D51853729

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 5, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51853729

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51853729

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Dec 5, 2023
)

Summary:

Attempt to solve/mitigate facebook#2043

We stopped pinning typeguard to 2.13.3, but gracefully failing if it doesn't have that version manually changes the version.  This is important so ax can install in a standard way without conflicting with user's other dependencies.

Reviewed By: mpolson64

Differential Revision: D51853729
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51853729

)

Summary:

Attempt to solve/mitigate facebook#2043

We stopped pinning typeguard to 2.13.3, but gracefully failing if it doesn't have that version manually changes the version.  This is important so ax can install in a standard way without conflicting with user's other dependencies.

Reviewed By: mpolson64

Differential Revision: D51853729
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51853729

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in a03bd24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants