Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GS inherit from GSInterface #1991

Closed
wants to merge 1 commit into from
Closed

Make GS inherit from GSInterface #1991

wants to merge 1 commit into from

Conversation

danielcohenlive
Copy link

Summary: Mainly this means implementing gen_multiple_with_ensembling()

Differential Revision: D51306927

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Nov 14, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 15, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
c97d5eb 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (b56610f) 94.47% compared to head (c473609) 94.51%.

❗ Current head c473609 differs from pull request most recent head 105c999. Consider uploading reports for the commit 105c999 to get more accurate results

Files Patch % Lines
ax/modelbridge/tests/test_generation_strategy.py 79.48% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1991      +/-   ##
==========================================
+ Coverage   94.47%   94.51%   +0.04%     
==========================================
  Files         460      460              
  Lines       44349    44388      +39     
==========================================
+ Hits        41898    41953      +55     
+ Misses       2451     2435      -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 16, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
4835a30 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 16, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
f077aa9 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 16, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
2e8c8e9 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 16, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
dab18d1 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 16, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
ed6c4ec 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 16, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
0fb010c 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 17, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
c97437f 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 17, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
352c4d7 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 21, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
4429cd2 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 21, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
750f517 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 21, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
e6d0861 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 29, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
cfdec65 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
21e1573 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
9cabcb0 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
7c7b32d 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
fa9adba 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
8a9e79f 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
3e0e6b4 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
3ffadbf 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
2d9dae7 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
2972dca 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
a2113bc 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
fe36125 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
105c999 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 30, 2023
@facebook-github-bot
Make GS inherit from GSInterface (facebook#1991)
df871e4 
Summary:

Mainly this means implementing `gen_multiple_with_ensembling()`

Reviewed By: lena-kashtelyan

Differential Revision: D51306927
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51306927

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in cc10088.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielcohenlive @facebook-github-bot @codecov-commenter