Finalize fix of not needing to store transition criterion on steps #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50752054 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 13, 2023
…acebook#1985) Summary: This diff: Finalizes the fix to the storage by removing the need to unset transiton criteria and doesn't store transition criterion anymore. It can do so because in the decoder we reconstruct the generation step, which automatically fills in the relevant node fields during its init method. Differential Revision: D50752054
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 14, 2023
…acebook#1985) Summary: This diff: Finalizes the fix to the storage by removing the need to unset transiton criteria and doesn't store transition criterion anymore. It can do so because in the decoder we reconstruct the generation step, which automatically fills in the relevant node fields during its init method. Reviewed By: lena-kashtelyan Differential Revision: D50752054
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 14, 2023
…acebook#1985) Summary: This diff: Finalizes the fix to the storage by removing the need to unset transiton criteria and doesn't store transition criterion anymore. It can do so because in the decoder we reconstruct the generation step, which automatically fills in the relevant node fields during its init method. Reviewed By: lena-kashtelyan Differential Revision: D50752054
mgarrard
force-pushed
the
export-D50752054
branch
from
dcd360b
to
6a3bc3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50752054 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
- Coverage 94.46% 94.46% -0.01%
==========================================
Files 460 460
Lines 44038 44034 -4
==========================================
- Hits 41599 41595 -4
Misses 2439 2439 ☔ View full report in Codecov by Sentry. |
…acebook#1985) Summary: This diff: Finalizes the fix to the storage by removing the need to unset transiton criteria and doesn't store transition criterion anymore. It can do so because in the decoder we reconstruct the generation step, which automatically fills in the relevant node fields during its init method. Reviewed By: lena-kashtelyan Differential Revision: D50752054
mgarrard
force-pushed
the
export-D50752054
branch
from
6a3bc3e
to
f84282b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50752054 |
|
This pull request has been merged in b3ee6c9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff:
Finalizes the fix to the storage by removing the need to unset transiton criteria and doesn't store transition criterion anymore. It can do so because in the decoder we reconstruct the generation step, which automatically fills in the relevant node fields during its init method.
Differential Revision: D50752054