Skip to content

Commit

Permalink
Switch legacy LCE-A to qLogNEI from legacy ei_or_nei (#2352)
Browse files Browse the repository at this point in the history
Summary:

Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of `GenerationStrategy`, which these classes hack around, so there's substantial maintenance burden to keeping them.

Context for this diff: LCE-A was depending on ALEBO for, it seems, no reason other than convenience of where the acquisition function constructor lived. This diff aims to address.

**[RfC] But also this made me wonder: maybe better to replace use of `ei_or_nei` in LCE-A with something newer?**

Reviewed By: saitcakmak

Differential Revision: D56037477
  • Loading branch information
Lena Kashtelyan authored and facebook-github-bot committed Apr 12, 2024
1 parent 8401990 commit d935cad
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions ax/models/torch/cbo_lcea.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@

from ax.core.search_space import SearchSpaceDigest
from ax.core.types import TCandidateMetadata
from ax.models.torch.alebo import ei_or_nei
from ax.models.torch.botorch import BotorchModel
from ax.models.torch.botorch_defaults import get_qLogNEI
from ax.models.torch.cbo_sac import generate_model_space_decomposition
from ax.models.torch_base import TorchModel, TorchOptConfig
from ax.utils.common.docutils import copy_doc
Expand Down Expand Up @@ -111,8 +111,7 @@ def __init__(
# pyre-fixme[4]: Attribute must be annotated.
self.train_embedding = self.gp_model_args.get("train_embedding", True)
super().__init__(
model_constructor=self.get_and_fit_model,
acqf_constructor=ei_or_nei, # pyre-ignore
model_constructor=self.get_and_fit_model, acqf_constructor=get_qLogNEI
)

@copy_doc(TorchModel.fit)
Expand Down

0 comments on commit d935cad

Please sign in to comment.