Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seq window derivation #44

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix seq window derivation #44

merged 1 commit into from
Mar 12, 2024

Conversation

LEAFERx
Copy link

@LEAFERx LEAFERx commented Feb 23, 2024

Background

  • Previously, when seq window of epoch E passed, derivation will create all empty batches belongs to E and the first empty batch belongs to E+1, even if seq window of epoch E+1 haven't passed yet
  • Since sequencer will only create l1 oracle update transaction at the first batch of an epoch, this prevents them being created forever once seq window passed

Core changes

  • Changed derivation pipeline behavior so that it creates empty batches for an epoch only when its seq window passed entirely, so sequencer will still have a chance to create l1 oracle update transactions

@ujvl ujvl merged commit 21f0425 into develop Mar 12, 2024
5 checks passed
@ujvl ujvl deleted the zhe/fix_seq_window_derivation branch March 12, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants