-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FabricObject): Render clipPath as sharp as the object #9774
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Build Stats
|
Also a bunch of strange results that needs investigations |
Note for myself: |
Did some test, scaling by zoomX and zoomY while works for a single nested clippath is not the way to go because it is too hard carry over the nested scaling to inner clippaths. In theory the main cache canvas of the object is always big enough ( and of course too big, but never too small ) The nested one needs to start drawing in a canvas that is the same as that one, but needs to carry over the transformation of the first clippath and then the second. |
It will still respect the fact that a parent is unique |
the clipPathParent is a temporary notation to see if things could work. |
Requires some extra testing for nested clipPaths and blurriness. |
Description
replace #7186
This PR prescale the canvas of the clipPath in order to be as scaled up as the object BEFORE drawing the actual Clippath on top of it.
It disable the extra cache of the clipPath but creates a throwAway canvas for each cache invalidation of the main object.
It improves SVG parsing for nested clipPaths