-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patch(Control): move hit detection to shouldActivate #9374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Stats
|
…icjs/fabric.js into move-detection-to-control-approach2
ShaMan123
approved these changes
Sep 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deeply disagree
This was referenced Sep 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
this is an alternative to #9731.
This is getting proposed as an alternative to the open PR because it doesn't add new code and reuse the existing one.
findCrossPoint should be exactly as good as finding a point inside a polygon if we remove the optimization at the end of the function that returns early after 2 matches.
This doesn't preclude any topic we briefly talked about as removing lineCoords, getting an hit detection from a complex polygon or other future optimizations.
I don't want to add this code to the Intersection class because i don't think the Intersection class should exist at all, but also is not something is a priority now.
Description
Changes
Gist
In Action