Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Canvas): setActiveObject should update canvas#_activeSelection #9336

Merged
merged 15 commits into from
Oct 2, 2023
Merged

fix(Canvas): setActiveObject should update canvas#_activeSelection #9336

merged 15 commits into from
Oct 2, 2023

Commits on Sep 14, 2023

  1. fix: getActiveObjects

    @zhe-he
    zhe-he committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    6698028 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @zhe-he
    zhe-he committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    ad1ab0f View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. add: test getactiveObjects

    @zhe-he
    zhe-he committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a60f056 View commit details
    Browse the repository at this point in the history

  2. add: test getactiveObjects

    @zhe-he
    zhe-he committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    5add9f1 View commit details
    Browse the repository at this point in the history

  3. Update src/shapes/ActiveSelection.spec.ts 

    Co-authored-by: Shachar <[email protected]>
    @zhe-he @ShaMan123
    zhe-he and ShaMan123 authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    0a31b6b View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md 

    Co-authored-by: Shachar <[email protected]>
    @zhe-he @ShaMan123
    zhe-he and ShaMan123 authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    51bcf36 View commit details
    Browse the repository at this point in the history

  5. update test

    @zhe-he
    zhe-he committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    6fac998 View commit details
    Browse the repository at this point in the history

  6. fix(): transferring object between active selections

    @ShaMan123
    ShaMan123 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    2ccfbde View commit details
    Browse the repository at this point in the history

  7. fix(): transferring object between active selections 2 

    This reverts commit 2ccfbde.

fix
    @ShaMan123
    ShaMan123 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    8f67b96 View commit details
    Browse the repository at this point in the history

  8. only if changed 

    Update SelectableCanvas.ts
    @ShaMan123
    ShaMan123 committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    5fc9171 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. update(src/canvas/SelectableCanvas.ts): _setActiveObject

    @zhe-he
    zhe-he committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    ca0b97e View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. no dispose 

    it is bad indeed to dispose
anyways it is safe to assume that the prev active selection has no children because it has been discarded and onDelect removed all the children
    @ShaMan123
    ShaMan123 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    c2340ae View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr/9336

    @ShaMan123
    ShaMan123 committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    40f5160 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Update SelectableCanvas.ts

    @ShaMan123
    ShaMan123 committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    5f0b627 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into pr/9336

    @ShaMan123
    ShaMan123 committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1ca7a0e View commit details
    Browse the repository at this point in the history