test(): migrate tests to playwright/jest #9333

ShaMan123 · 2023-09-13T23:31:06Z

Motivation

Description

Working on #9329 unconvered many ubgs.
Trying to fix them made tests fail.
These tests are not human friendly, they dump endless output onto the console so they are useless.
To be percise draggable_text was written by me while grinding my teeth. It was hard and I knew it was incorrect to write it like that.
So I have moved draggable_text to e2e as it should be, removing redundancies.
And I have moved all the findTarget related tests to jest.

Changes

Gist

In Action

`_searchPossibleTargets` => `fintTargetsTraversal`

t Update eventData.test.ts

a real fix fix fix f Update StackedObject.ts fix

cleanup Update canvas_events.js hovering state

Avoid firing twice

github-actions · 2023-09-13T23:33:05Z

Build Stats

file / KB (diff)	bundled	minified
fabric	907.643 (0)	304.633 (0)

v

ShaMan123

reverted, now only tests are here and #9329

ShaMan123 · 2023-09-13T23:32:44Z

e2e/tests/text/drag&drop/index.spec.ts-snapshots/4-events.json

+    "canvas"
+  ],
+  [
+    "dragleave",


weird, a bug.
after dragstart nothing has entered yet

ShaMan123 · 2023-09-13T23:34:14Z

e2e/tests/text/drag&drop/index.spec.ts-snapshots/5-events.json

+    "dragenter",
+    {
+      "e": {
+        "isTrusted": true
+      },
+      "target": "a",
+      "subTargets": [],
+      "dragSource": "b"
+    },
+    "canvas"
+  ],
+  [
+    "dragleave",
+    {
+      "subTargets": [],
+      "dragSource": "b",
+      "e": {
+        "isTrusted": true
+      },
+      "target": "b",
+      "nextTarget": "a",
+      "isClick": false,
+      "pointer": {
+        "x": 120,
+        "y": 55
+      },
+      "absolutePointer": {
+        "x": 120,
+        "y": 55
+      }
+    },
+    "b"
+  ],


here canvas says b is entering while b is saying it is leaving

ShaMan123

@asturur please merge this
The tests in this PR are much more freindly and reliable - I have PRs with tests that are failing, tests that are migrated here.

ShaMan123

It seems that tests are failing becuase of font differences.
We need to register the font - the code you removed from the other CI PR

ShaMan123 · 2023-11-20T07:54:00Z

e2e/tests/text/drag&drop/index.ts

+        ...(pointer ? { pointer: roundPoint(pointer) } : {}),
+        ...(absolutePointer
+          ? { absolutePointer: roundPoint(absolutePointer) }


scenePoint/viewportPoint

github-actions · 2024-01-20T19:10:18Z

Coverage after merging test-etc into master will be

82.71%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
index.node.ts	14.29%	100%	0%	25%	23, 26, 29, 41, 44, 47
src
ClassRegistry.ts	100%	100%	100%	100%
Collection.ts	94.85%	94.83%	87.10%	97.14%	109, 112, 215–216, 241–242
CommonMethods.ts	96.55%	87.50%	100%	100%	9
Intersection.ts	100%	100%	100%	100%
Observable.ts	87.76%	85.29%	87.50%	89.58%	134–135, 160–161, 32–33, 41, 50, 78, 89
Point.ts	100%	100%	100%	100%
Shadow.ts	98.36%	95.65%	100%	100%	178
cache.ts	97.06%	90%	100%	100%	57
config.ts	74.14%	65%	66.67%	82.76%	131, 139, 139, 139, 139, 139–141, 152–154, 30
constants.ts	100%	100%	100%	100%
src/LayoutManager
LayoutManager.ts	87.50%	89.29%	76.92%	90%	133–134, 136–137, 137, 137, 137, 137, 231, 289–290, 301, 46
constants.ts	100%	100%	100%	100%
src/LayoutManager/LayoutStrategies
ClipPathLayout.ts	82.05%	72.22%	100%	88.89%	30–31, 42, 54, 57–58, 65
FitContentLayout.ts	100%	100%	100%	100%
FixedLayout.ts	20%	0%	0%	40%	20–21, 23, 23, 23, 23, 23
LayoutStrategy.ts	86%	64.71%	100%	96.15%	36, 43, 43, 43, 51, 71–72
utils.ts	91.67%	85.71%	100%	100%	28, 34
src/Pattern
Pattern.ts	90.54%	93.94%	80%	90.32%	119, 130, 139, 32, 36
src/brushes
BaseBrush.ts	100%	100%	100%	100%
CircleBrush.ts	0%	0%	0%	0%	108, 108, 108, 110, 112, 114–116, 118–121, 128–129, 13, 136, 138, 23–24, 32–36, 40–44, 51–54, 62–66, 68, 76, 76, 76, 76, 76–77, 79, 79, 79–82, 84, 92–93, 95, 97–99
PatternBrush.ts	97.06%	87.50%	100%	100%	21
PencilBrush.ts	91.06%	82.35%	100%	93.81%	122–123, 152, 152–154, 176, 176, 276, 280, 285–286, 68–69, 84–85
SprayBrush.ts	0%	0%	0%	0%	107, 107, 107, 107, 107–108, 110–111, 118–119, 121, 123–127, 136, 140–141, 141, 148, 148, 148–151, 153–156, 160–161, 163, 165–168, 17, 171, 178–179, 18, 181, 183–184, 186, 193–194, 196–197, 20, 200, 200, 207, 207, 21, 211, 22, 22, 22–24, 28, 32, 39, 46, 53, 60, 67, 84–86, 94–96, 98–99
src/canvas
Canvas.ts	78.66%	77.04%	82.14%	79.33%	1001–1003, 1006–1007, 1011–1012, 1123–1125, 1128–1129, 1202, 1314, 1435, 158, 183, 289, 289–294, 299, 322–323, 328–333, 353, 353, 353–354, 354, 354–355, 363, 368–369, 369, 369–370, 372, 381, 387–388, 388, 388, 42, 431, 439, 443, 443, 443–444, 446, 46, 528–529, 529, 529–530, 536, 536, 536–538, 558, 560, 560, 560–561, 561, 561, 564, 564, 564–565, 568, 577–578, 580–581, 583, 583–584, 586–587, 599–600, 600, 600–601, 603–608, 614, 621, 658, 658, 658, 660, 662–667, 673, 679, 679, 679–680, 682, 685, 690, 703, 731, 783–784, 784, 784, 784, 784, 784, 787–788, 791, 791–793, 796–797, 879, 886, 886, 886, 899, 928–929, 929, 929–931, 934–935, 935, 935, 937, 945, 945, 945–947, 947, 947, 954–955, 963–964, 964, 964–965, 971, 973
CanvasOptions.ts	100%	100%	100%	100%
SelectableCanvas.ts	90.22%	87.30%	94.55%	91.74%	1004, 1012, 1123, 1125, 1127–1128, 1199, 1220–1221, 1239–1240, 460–461, 463–464, 464, 464, 513–514, 591, 596, 666, 671–672, 699–700, 724, 727–730, 730, 730–731, 731, 731, 737–738, 740, 760–761, 766–770, 772, 807–808, 811, 811, 811–812, 931, 931–932, 935, 955, 955
StaticCanvas.ts	96.51%	93.04%	98.91%	98.28%	1014, 1024, 1075–1077, 1080, 1115–1116, 1192, 1201, 1201, 1205, 1205, 1252–1253, 179–180, 196, 554, 566–567, 897–898, 898, 898–899
StaticCanvasOptions.ts	100%	100%	100%	100%
TextEditingManager.ts	86%	71.43%	91.67%	91.67%	17, 17, 17–18, 18, 18
src/canvas/DOMManagers
CanvasDOMManager.ts	95.52%	70%	100%	100%	21–22, 29
StaticCanvasDOMManager.ts	97.50%	88.89%	100%	100%	33
util.ts	86.67%	80.56%	83.33%	93.94%	14, 26, 63–64, 67, 67, 74, 93–94
src/color
Color.ts	94.96%	91.67%	96.30%	96.05%	233, 258–259, 267–268, 48
color_map.ts	100%	100%	100%	100%
constants.ts	100%	100%	100%	100%
util.ts	85.71%	76.92%	100%	89.74%	55–56, 56, 58, 58, 58–59, 61–62, 89
src/controls
Control.ts	94.44%	93.10%	91.67%	96.77%	183, 249, 354
changeWidth.ts	100%	100%	100%	100%
commonControls.ts	100%	100%	100%	100%
controlRendering.ts	81.63%	78%	100%	84.78%	106, 111, 121, 121, 45, 50, 61, 61, 65–72, 81–82
drag.ts	100%	100%	100%	100%
fireEvent.ts	88.89%	75%	100%	100%	13
polyControl.ts	10.87%	0%	0%	16.13%	114, 114, 114, 114, 114, 116–119, 119, 122, 129, 24–26, 50–52, 58–59, 61, 71, 77–79, 79, 81, 84, 86, 90–92, 94, 99
rotate.ts	19.57%	12.50%	50%	21.43%	41, 45, 51, 51, 51–52, 55–57, 59, 59,

asturur · 2024-01-20T19:18:29Z

I ll make an issue with a followup for this PR since the the position of the mouse should be refactored with the proper text utils where possible.
Also one test for me doesn't pass locally

ShaMan123 · 2024-01-20T21:05:53Z

I ll make an issue with a followup for this PR since the the position of the mouse should be refactored with the proper text utils where possible. Also one test for me doesn't pass locally

My point of view on this is that we should use hardcoded position because it makes the test strict.
If we use a function that depends on what we are testing then the test becomes weaker, don't you think?

jiayihu and others added 16 commits September 12, 2023 15:37

Avoid firing twice

d64f256

Update eventData.test.ts

9ad919c

fix bug + add test

ace9a13

`_searchPossibleTargets` => `fintTargetsTraversal`

Update CHANGELOG.md

779e80c

migrate test

37ff3dc

migrate findTarget tests

bdafc1b

t Update eventData.test.ts

a real fix

f8798c6

a real fix fix fix f Update StackedObject.ts fix

hovering state

b1e5144

cleanup Update canvas_events.js hovering state

Update Canvas.ts

61eb555

consume drag tests

7e7d1c8

event stream tests

c99c8b9

better tests

feec910

add textarea tests

df80bfb

adaptions

9d103f6

cleanup snapshots

a3276e4

revert

0b75ea4

Avoid firing twice

revert tests

d5cddcd

v

ShaMan123 force-pushed the test-etc branch from bccb40c to d5cddcd Compare September 13, 2023 23:40

ShaMan123 commented Sep 13, 2023

View reviewed changes

Update eventData.test.ts

29353d8

ShaMan123 requested a review from asturur September 13, 2023 23:47

ShaMan123 mentioned this pull request Sep 15, 2023

fix(): searchPossibleTargets targets value #9343

Closed

ShaMan123 added 2 commits September 24, 2023 11:41

Merge branch 'master' into test-etc

18cedc9

fix test

ab6af44

ShaMan123 added the CI/CD label Sep 24, 2023

ShaMan123 added 2 commits September 24, 2023 12:19

checkout Canvas changes

d15d861

checkout StackedObject typing

36dcd68

ShaMan123 commented Sep 24, 2023

View reviewed changes

ShaMan123 mentioned this pull request Sep 24, 2023

fix(Geometry): containsPoint - BREAKING Canvas#_checkTarget #9372

Merged

ShaMan123 mentioned this pull request Sep 25, 2023

BREAKING refactor(Intersection): support ray intersection #9371

Closed

ShaMan123 added 4 commits September 27, 2023 07:54

Merge branch 'master' into test-etc

977a9e9

Update CHANGELOG.md

5d8065c

Update eventData.test.ts

7860f9c

increase accuracy

1fe0660

ShaMan123 commented Sep 27, 2023

View reviewed changes

ShaMan123 mentioned this pull request Nov 6, 2023

tests(): Start moving visual tests to playwright #9481

Merged

ShaMan123 commented Nov 20, 2023

View reviewed changes

asturur added 6 commits January 20, 2024 18:34

Update CHANGELOG.md

16f4108

fixed merge master

fa93e65

update snaps

a9d0524

jsons events

df75426

fix this manually

42abbfd

cant rewrite

ba2c431

asturur approved these changes Jan 20, 2024

View reviewed changes

asturur merged commit 432e1ad into master Jan 20, 2024
22 checks passed

asturur deleted the test-etc branch January 20, 2024 19:19

asturur mentioned this pull request Jan 20, 2024

Follow for drag drop e2e test. #9611

Open

ShaMan123 mentioned this pull request May 7, 2024

WIP fix(): searchPossibleTargets targets value ShaMan123/fabric.js#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(): migrate tests to playwright/jest #9333

test(): migrate tests to playwright/jest #9333

ShaMan123 commented Sep 13, 2023

github-actions bot commented Sep 13, 2023 •

edited

Loading

ShaMan123 left a comment

ShaMan123 Sep 13, 2023

ShaMan123 Sep 13, 2023

ShaMan123 left a comment

ShaMan123 left a comment

ShaMan123 Nov 20, 2023

github-actions bot commented Jan 20, 2024

asturur commented Jan 20, 2024

ShaMan123 commented Jan 20, 2024

test(): migrate tests to playwright/jest #9333

test(): migrate tests to playwright/jest #9333

Conversation

ShaMan123 commented Sep 13, 2023

Motivation

Description

Changes

Gist

In Action

github-actions bot commented Sep 13, 2023 • edited Loading

ShaMan123 left a comment

Choose a reason for hiding this comment

ShaMan123 Sep 13, 2023

Choose a reason for hiding this comment

ShaMan123 Sep 13, 2023

Choose a reason for hiding this comment

ShaMan123 left a comment

Choose a reason for hiding this comment

ShaMan123 left a comment

Choose a reason for hiding this comment

ShaMan123 Nov 20, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 20, 2024

asturur commented Jan 20, 2024

ShaMan123 commented Jan 20, 2024

github-actions bot commented Sep 13, 2023 •

edited

Loading