-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING feat(setActiveObject
): startImmediatePropagation
#9099
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaMan123
changed the title
BREAKING: feat():
BREAKING feat(): Jul 16, 2023
startImmediatePropagation
startImmediatePropagation
Build Stats
|
ShaMan123
changed the title
BREAKING feat():
BREAKING feat(Jul 16, 2023
startImmediatePropagation
setActiveObject
): startImmediatePropagation
ShaMan123
commented
Jul 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- squashed
_beforeTransform
into_setupCurrentTransform
commit 1849a03 Author: ShaMan123 <[email protected]> Date: Thu Jul 20 01:15:16 2023 +0530 Update playwright.config.ts commit fd4102f Author: ShaMan123 <[email protected]> Date: Wed Jul 19 23:19:45 2023 +0530 Update setupApp.ts Revert "Update setupApp.ts" This reverts commit 5dcd615. commit ec4ac28 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 22:38:04 2023 +0530 fix transforming error commit b7edf37 Merge: 3aaa04b 73fa847 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 22:31:09 2023 +0530 Merge branch 'master' into ci-e2e-rel-imports commit 3aaa04b Author: ShaMan123 <[email protected]> Date: Wed Jul 19 22:23:19 2023 +0530 cleanup commit ced8451 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 17:21:54 2023 +0530 abs resolution + default imports abs resolution + default imports commit 4f7bda2 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 15:08:58 2023 +0530 cleanup commit 47b954f Author: ShaMan123 <[email protected]> Date: Wed Jul 19 14:38:09 2023 +0530 node version - this was supposed to throw commit 6ccd23c Author: ShaMan123 <[email protected]> Date: Wed Jul 19 14:33:35 2023 +0530 try to fix node14 ci error actions/setup-node#214 (comment) npm/npm#19788 commit cb31f22 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 14:09:57 2023 +0530 Update package-lock.json commit 248d0be Author: ShaMan123 <[email protected]> Date: Wed Jul 19 13:59:48 2023 +0530 forgot the setup commit 19e20d3 Merge: b9c0da6 f09a52e Author: ShaMan123 <[email protected]> Date: Wed Jul 19 13:54:49 2023 +0530 Merge branch 'ci-e2e-rel-imports' of https://github.com/fabricjs/fabric.js into ci-e2e-rel-imports commit b9c0da6 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 13:54:25 2023 +0530 extends commit f09a52e Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Wed Jul 19 08:22:08 2023 +0000 update CHANGELOG.md commit 20b9eaa Author: ShaMan123 <[email protected]> Date: Wed Jul 19 13:49:28 2023 +0530 ci(e2e): support relative imports
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs 😔. Thank you for your contributions. |
closing this in favor of ShaMan123#2 => |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
First merge #9108
Using the concept and naming of
stopImmediatePropagation
,Changes
Calling
_setupCurrentTransform
fromsetActiveObject
BREAKING
setActiveObject
,_setActiveObject
signature =>(object, e)
=>(object, options: { e, startImmediatePropagation })
Gist
In Action
https://codesandbox.io/s/4l58sp
Playwright
video.webm
Master
video.webm