Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] This is just a reminder of safari 13 extra size #8917

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

asturur
Copy link
Member

@asturur asturur commented May 13, 2023

Just a built lib to see how much extra code we have for safari 13
This is not mean to be merged for release 6

@asturur asturur changed the title [DRAF] This is just a reminder of safari 13 extra size [DRAFT] This is just a reminder of safari 13 extra size May 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2023

Build Stats

file / KB (diff) bundled minified
fabric 909.744 (-10.466) 300.896 (-5.902)

@asturur
Copy link
Member Author

asturur commented May 13, 2023

There are still 50 occurrences of

let aValue = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 1;

That could be removed if i could understand which browser introduces them

@ShaMan123
Copy link
Contributor

nice

@stale
Copy link

stale bot commented Aug 12, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs 😔. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Aug 12, 2023
@ShaMan123 ShaMan123 removed the stale Issue marked as stale by the stale bot label Aug 14, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs 😔. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Sep 17, 2023
@stale stale bot removed the stale Issue marked as stale by the stale bot label Jan 20, 2024
Copy link
Contributor

Coverage after merging just-safari-13-reminder into master will be

83.76%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
index.node.ts14.29%100%0%25%23, 26, 29, 41, 44, 47
extensions/aligning_guidelines/util
   basic.ts100%100%100%100%
src
   ClassRegistry.ts91.18%64.29%100%97.92%35, 56
   Collection.ts71.39%31.15%45.16%83.91%130, 138, 153, 155–157, 159, 169–170, 180–181, 197, 215, 217, 219, 228, 243, 254, 263, 265, 270, 279, 281, 283, 286–287, 302, 304, 306, 309–310, 327–328, 328, 328–329, 333–334, 337–344, 346–348, 350, 75, 99
   CommonMethods.ts88.57%64.29%83.33%96%50, 52, 9
   Intersection.ts81.42%41.30%73.33%96.14%105, 132–133, 166, 184–190, 228, 228, 237, 239, 289–291, 297, 297, 78, 80
   Observable.ts72.25%44.19%31.25%86.36%144, 153, 156, 168, 170, 172, 175, 41, 43, 68–70, 72, 76, 78, 80, 82–85, 87–91
   Point.ts84.95%62%44.12%92.68%104, 117, 148, 157, 179, 197, 206, 216, 225, 236–239, 259, 284–285, 294–297, 328, 341, 349, 359, 95
   Shadow.ts80.91%13.04%37.50%90%139, 139–140, 140–141, 143, 145–150, 159, 176, 176, 176, 176, 194, 194, 196–197, 197, 199, 206, 206, 223–230, 232, 232, 234–235
   cache.ts83.72%45.45%75%90.14%57, 59, 71–72, 74–77
   config.ts82.21%20%44.44%94.03%123, 131–132, 134–137, 139, 142–143, 147, 152, 152, 152, 152, 152, 152
   constants.ts100%100%100%100%
src/LayoutManager
   ActiveSelectionLayoutManager.ts83.33%61.54%28.57%100%43, 47
   LayoutManager.ts89.28%65.48%53.85%99.31%279, 344, 355
   constants.ts100%100%100%100%
   index.ts48.57%37.50%80%66.67%1, 1, 1–2, 2, 2–3, 3, 3–4, 4, 4–5, 5, 5, 5–6
   types.ts100%100%100%100%
src/LayoutManager/LayoutStrategies
   ClipPathLayout.ts71.05%37.50%100%78.95%39, 41–44, 46–48, 54, 57–58, 66–69
   FitContentLayout.ts100%100%100%100%
   FixedLayout.ts85.71%20%100%100%23, 23
   LayoutStrategy.ts84.30%50%71.43%96.51%46, 52, 54, 73, 73, 75, 88
   utils.ts62.90%7.14%100%78.72%28–32, 34–35, 39, 39–44, 47, 47, 47
src/Pattern
   Pattern.ts54.39%3.03%10%65.95%105–107, 113, 113–114, 117, 117–119, 119, 119–122, 130, 130–132, 132, 132, 132, 132, 132–138, 140–141, 143, 150, 150, 150, 150, 153–160, 160, 160–164, 174–175, 175, 175, 175–176, 176, 176–182, 182, 182, 182–183, 183, 183–188, 190–199, 204–205, 207–209, 211, 33, 37
src/brushes
   BaseBrush.ts78.67%8.33%14.29%88.55%110, 114, 114–115, 122, 122, 122, 122, 124–125, 130, 135, 143, 146, 155, 155, 155, 155, 155–160, 99
   CircleBrush.ts52.10%12.50%12.50%58.25%100–108, 108–118, 122, 130–139, 55, 67, 69, 76, 76, 78–79, 79, 83, 85–86, 92–98
   PatternBrush.ts97.06%87.50%100%100%21
   PencilBrush.ts91.06%82.35%100%93.81%122–123, 152, 152–154, 176, 176, 276, 280, 285–286, 68–69, 84–85
   SprayBrush.ts0%0%0%0%107, 107, 107, 107, 107–108, 110–111, 118–119, 121, 123–127, 136, 140–141, 141, 148, 148, 148–151, 153–156, 160–161, 163, 165–168, 17, 171, 178–179, 18, 181, 183–184, 186, 193–194, 196–197, 20, 200, 200, 207, 207, 21, 211, 22, 22, 22–24, 28, 32, 39, 46, 53, 60, 67, 84–86, 94–96, 98–99
src/canvas
   Canvas.ts71.29%30.59%78.57%82.72%1000, 1005, 1009, 1013–1014, 1019, 1032–1033, 1048, 1050, 1050, 1059, 1062, 1064–1069, 1106, 1127, 1131, 1136, 1138, 1141, 117, 1204–1208, 1253, 1261, 1286–1291, 1294, 1317–1318, 1335, 1380–1398, 1400–1410, 1410, 1410–1417, 1419, 1421–1422, 1424–1426, 1430, 1432, 1434–1436, 1439–1444, 1447–1449, 1452, 1454, 1466, 1468, 1475, 1477–1493, 1493–1494, 1496–1497, 1501–1502, 1505–1506, 1509–1511, 1514, 184, 319, 329, 354, 370, 389, 432, 444, 560–564, 567–568, 570, 580, 583–584, 586, 589–591, 603, 610–614, 616–621, 623–627, 660, 662, 669–673, 675–680, 682, 684–685, 687–690, 692–693, 704, 748, 784–787, 790, 792, 792, 795, 797, 799, 825, 831–832, 834, 840–841, 844–846, 848–852, 855–862, 868, 871, 871, 885, 888, 900, 933–934, 937, 939, 946, 949–954, 957, 965–973, 975, 996–997
   CanvasOptions.ts100%100%100%100%
   SelectableCanvas.ts83.49%49.24%80%94.21%1006, 1008–1009, 1026, 1035, 1103–1107, 1153–1154, 1156–1157, 1159, 1186, 1188–1189, 1189, 1191, 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants