-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(): reproduction templates + sandbox deploy #8803
Conversation
Build Stats
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready to merge
@@ -39,8 +40,11 @@ export async function createCodeSandbox(appPath) { | |||
); | |||
// omit linked package | |||
if (packageJSON.dependencies.fabric.startsWith('file:')) { | |||
packageJSON.dependencies.fabric = '*'; | |||
const { repo, branch } = getGitInfo(); | |||
packageJSON.dependencies.fabric = `${repo}#${branch}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installs from github
great for PRs
I guess CodesandboxCI handles this under the hood but for now this is great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done!
8f5084b
to
c35359f
Compare
This reverts commit c35359f.
* chore(): update 🐛 Bug Report * chore(): update 🐛 Bug Report --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
future proofed for next majors!
That was easy! |
I overlooked the fact that we need to keep the old repro templates for v5 |
…bric.js into ci-sandbox-templates
ws readme better Update bug_report.yml table table md is not support in yml ws Update package.json
337a9ea
to
b7c7c21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restored v5 repro links
waiting for approval and merge
Motivation
Description
Changes
Gist
In Action