ci(): reproduction templates + sandbox deploy #8803

ShaMan123 · 2023-03-24T08:00:31Z

Motivation

Description

updated reproduction templates in the issue template for v6 and v5
added the beta tag to the npmpublish workflow so the version dropdown of the issue template reflects it
updated the sandbox deploy script to use the branch of fabric that deployed it

Changes

extracted git command logic from scripts/index to scripts/git

Gist

In Action

github-actions · 2023-03-24T08:02:56Z

Build Stats

file / KB (diff)	bundled	minified
fabric	895.394 (0)	304.351 (0)

github-actions · 2023-03-24T08:03:47Z

Coverage after merging ci-sandbox-templates into master will be

83.71%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
index.node.ts	7.69%	100%	0%	14.29%	17, 20, 23, 29, 32, 35
src
ClassRegistry.ts	100%	100%	100%	100%
Collection.ts	94.71%	94.64%	86.67%	97.09%	100, 103, 206–207, 232–233
CommonMethods.ts	96.55%	87.50%	100%	100%	10
Intersection.ts	100%	100%	100%	100%
Observable.ts	87.23%	85.29%	84.62%	89.36%	144–145, 170–171, 39–40, 48, 57, 91, 99
Pattern.ts	92.21%	91.89%	90%	93.33%	114, 138, 149, 158, 51
Point.ts	100%	100%	100%	100%
Shadow.ts	98.51%	96%	100%	100%	168
cache.ts	97.06%	90%	100%	100%	56
config.ts	75%	66.67%	66.67%	82.76%	130, 138, 138, 138, 138, 138–140, 151–153
constants.ts	100%	100%	100%	100%
typedefs.ts	100%	100%	100%	100%
src/brushes
BaseBrush.ts	100%	100%	100%	100%
CircleBrush.ts	0%	0%	0%	0%	100, 102–104, 113, 113, 113, 115, 117, 119–121, 123–126, 133–134, 141, 143, 28–29, 37–41, 45–49, 56–59, 67–71, 73, 81, 81, 81, 81, 81–82, 84, 84, 84–87, 89, 97–98
PatternBrush.ts	97.06%	87.50%	100%	100%	21
PencilBrush.ts	91.01%	82.35%	100%	93.75%	122–123, 152, 152–154, 176, 176, 276, 280, 285–286, 68–69, 84–85
SprayBrush.ts	0%	0%	0%	0%	100–101, 103–104, 112, 112, 112, 112, 112–113, 115–116, 123–124, 126, 128–132, 141, 145–146, 146, 154, 154, 154–157, 159–162, 166–167, 169, 171–174, 177, 184–185, 187, 189–190, 192, 199–200, 202–203, 206, 206, 213, 213, 217, 22–23, 25–27, 27, 27–29, 33, 42, 49, 56, 63, 70, 89–91, 99
src/canvas
Canvas.ts	78.98%	77.54%	81.67%	79.60%	1000, 1000, 1000–1002, 1004–1005, 1005, 1005, 1007, 1015, 1015, 1015–1017, 1017, 1017, 1023–1024, 1032–1033, 1033, 1033–1034, 1039, 1041, 1072–1074, 1077–1078, 1082–1083, 1197–1199, 1202–1203, 1276, 1396, 1519, 1589, 161, 186, 295–296, 299–303, 308, 331–332, 337–342, 36, 362, 362, 362–363, 363, 363–364, 372, 377–378, 378, 378–379, 381, 390, 396–397, 397, 397, 40, 440, 448, 452, 452, 452–453, 455, 537–538, 538, 538–539, 545, 545, 545–547, 567, 569, 569, 569–570, 570, 570, 573, 573, 573–574, 577, 586–587, 589–590, 592, 592–593, 595–596, 608–609, 609, 609–610, 612–616, 622, 629, 669, 669, 669, 671, 673–677, 683, 689, 689, 689–690, 692, 695, 700, 713, 740, 740, 798–799, 799, 799–800, 802, 805–806, 806, 806–807, 809–810, 813, 813–815, 818–819, 889, 901, 908, 929, 961, 982–983, 999
SelectableCanvas.ts	94.39%	91.16%	94.55%	96.63%	1127, 1127–1128, 1131, 1151, 1151, 1209, 1262–1263, 1284, 1292, 1417, 1419, 1421–1422, 526, 706–707, 709–710, 710, 710, 759–760, 821–822, 875–877, 909, 914–915, 942–943
StaticCanvas.ts	96.01%	91.48%	100%	97.93%	1112–1113, 1113, 1113–1114, 1234, 1244, 1298–1299, 1302, 1337–1338, 1415, 1424, 1424, 1428, 1428, 1475–1476, 1690–1691, 311–312, 329, 409–410, 412–413, 774, 786–787, 872
TextEditingManager.ts	100%	100%	100%	100%
src/color
Color.ts	92.16%	86.49%	100%	94.29%	330–331, 335–336, 339–340, 58, 88–89, 89, 91, 91, 91–92, 94–95
color_map.ts	100%	100%	100%	100%
constants.ts	100%	100%	100%	100%
util.ts	100%	100%	100%	100%
src/controls
Control.ts	93.90%	88.89%	90.91%	97.73%	235, 319, 319, 354
changeWidth.ts	100%	100%	100%	100%
commonControls.ts	100%	100%	100%	100%
controlRendering.ts	81.63%	78%	100%	84.78%	106, 111, 121, 121, 45, 50, 61, 61, 65–72, 81–82
drag.ts	100%	100%	100%	100%
polyControl.ts	5.97%	0%	0%	11.11%	100, 105, 119, 119, 119, 119, 119, 121–124, 124, 127, 134, 17, 25–29, 29, 29, 29, 29, 29, 29, 29, 50–56, 56, 56, 56, 56, 58, 63–64, 66, 76, 82–83, 83, 83–84, 88–90, 90, 90, 90, 90, 92
rotate.ts	19.57%	12.50%	50%	21.43%	41, 45, 51, 51, 51–52, 55–57, 59, 59, 59, 59, 59–61, 61, 61–63, 65, 65, 65–67, 67, 67–68, 73, 73, 73–74, 76, 78, 80–81
scale.ts	93.57%	92.94%	100%	93.67%	129–130, 132–134, 148–149, 181–183, 42
scaleSkew.ts	78.79%	64.29%	100%	85.71%	27, 29, 29, 29, 31, 33, 35
skew.ts	91.03%	79.31%	100%	97.67%	130–131, 162–163, 170, 176, 178
util.ts	100%	100%	100%	100%
wrapWithFireEvent.ts	100%	100%	100%	100%
wrapWithFixedAnchor.ts	100%	100%	100%	100%
src/env
browser.ts	84.21%	77.78%	50%	100%	14, 17
index.ts	91.67%	50%	100%	100%	20
node.ts	76.92%	50%	66.67%	88.24%	27, 31–32, 32, 32
src/filters
BaseFilter.ts	21.93%	22.81%	32%	19.05%	106–109, 109, 109–110, 116, 116, 116–119, 137, 155, 169–174, 178–179, 179, 179–182,

ShaMan123

ready to merge

ShaMan123 · 2023-03-24T10:36:56Z

.codesandbox/deploy.mjs

@@ -39,8 +40,11 @@ export async function createCodeSandbox(appPath) {
  );
  // omit linked package
  if (packageJSON.dependencies.fabric.startsWith('file:')) {
-    packageJSON.dependencies.fabric = '*';
+    const { repo, branch } = getGitInfo();
+    packageJSON.dependencies.fabric = `${repo}#${branch}`;


installs from github
great for PRs
I guess CodesandboxCI handles this under the hood but for now this is great

ShaMan123

done!

This reverts commit c35359f.

* chore(): update 🐛 Bug Report * chore(): update 🐛 Bug Report --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

ShaMan123

future proofed for next majors!

ShaMan123 · 2023-03-24T11:45:49Z

That was easy!

ShaMan123 · 2023-03-24T11:48:25Z

I overlooked the fact that we need to keep the old repro templates for v5
pushing now

…bric.js into ci-sandbox-templates

ws readme better Update bug_report.yml table table md is not support in yml ws Update package.json

ShaMan123

restored v5 repro links
waiting for approval and merge

ShaMan123 added 3 commits March 24, 2023 10:57

Update README.md

0a5baf6

local dep

b12846d

patch deploy script

04ac1d4

ShaMan123 added the CI/CD label Mar 24, 2023

ShaMan123 requested a review from asturur March 24, 2023 08:00

Update npmpublish.yml

2451c58

ShaMan123 added 9 commits March 24, 2023 11:09

Update start.mjs

9e97a43

trailing slash

180a014

Update package.json

67c8365

Update CONTRIBUTING.md

004bbcb

Update CONTRIBUTING.md

9f79446

Update CONTRIBUTING.md

f5f1026

Update CONTRIBUTING.md

90c9060

links

972654f

readme

23e0cec

ShaMan123 commented Mar 24, 2023

View reviewed changes

ShaMan123 added 2 commits March 24, 2023 13:45

typo

79eab82

Update bug_report.yml

e645dc7

ShaMan123 commented Mar 24, 2023

View reviewed changes

Update CHANGELOG.md

8d0bcb3

ShaMan123 changed the title ~~ci(): sandbox deploy + reproduction templates~~ ci(): reproduction templates + sandbox deploy Mar 24, 2023

ShaMan123 added 5 commits March 24, 2023 14:01

Update README.md

39e5669

Update README.md

c3aa72d

Update README.md

63cf63c

Latest major version for bug report update

24cc280

revertable test

c35359f

ShaMan123 force-pushed the ci-sandbox-templates branch from 8f5084b to c35359f Compare March 24, 2023 11:27

Update npmpublish.yml

ede4b14

ShaMan123 and others added 2 commits March 24, 2023 14:31

Revert "revertable test"

0cc1b92

This reverts commit c35359f.

chore(): Update bug report (#8804)

ba97827

* chore(): update 🐛 Bug Report * chore(): update 🐛 Bug Report --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

ShaMan123 commented Mar 24, 2023

View reviewed changes

asturur previously approved these changes Mar 24, 2023

View reviewed changes

ShaMan123 added 2 commits March 24, 2023 14:51

Update bug_report.yml

74287fd

Merge branch 'ci-sandbox-templates' of https://github.com/fabricjs/fa…

4bd4652

…bric.js into ci-sandbox-templates

ShaMan123 dismissed asturur’s stale review via 4bd4652 March 24, 2023 11:51

restore v5 5repro links

b7c7c21

ws readme better Update bug_report.yml table table md is not support in yml ws Update package.json

ShaMan123 force-pushed the ci-sandbox-templates branch from 337a9ea to b7c7c21 Compare March 24, 2023 12:43

ShaMan123 commented Mar 24, 2023

View reviewed changes

ShaMan123 requested a review from asturur March 24, 2023 12:45

asturur approved these changes Mar 27, 2023

View reviewed changes

asturur merged commit e451176 into master Mar 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci(): reproduction templates + sandbox deploy #8803

ci(): reproduction templates + sandbox deploy #8803

ShaMan123 commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023

github-actions bot commented Mar 24, 2023 •

edited

Loading

ShaMan123 left a comment

ShaMan123 Mar 24, 2023

ShaMan123 left a comment

ShaMan123 left a comment

ShaMan123 commented Mar 24, 2023

ShaMan123 commented Mar 24, 2023 •

edited

Loading

ShaMan123 left a comment

ci(): reproduction templates + sandbox deploy #8803

ci(): reproduction templates + sandbox deploy #8803

Conversation

ShaMan123 commented Mar 24, 2023 • edited Loading

Motivation

Description

Changes

Gist

In Action

github-actions bot commented Mar 24, 2023

github-actions bot commented Mar 24, 2023 • edited Loading

ShaMan123 left a comment

Choose a reason for hiding this comment

ShaMan123 Mar 24, 2023

Choose a reason for hiding this comment

ShaMan123 left a comment

Choose a reason for hiding this comment

ShaMan123 left a comment

Choose a reason for hiding this comment

ShaMan123 commented Mar 24, 2023

ShaMan123 commented Mar 24, 2023 • edited Loading

ShaMan123 left a comment

Choose a reason for hiding this comment

ShaMan123 commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading

ShaMan123 commented Mar 24, 2023 •

edited

Loading