-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IText): layout regression #8711
Conversation
caused by #8663
Build Stats
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asturur take a look
_shouldClearDimensionCache() { | ||
const shouldClear = this._forceClearCache; | ||
if (shouldClear) { | ||
this.dirty = true; | ||
this._forceClearCache = false; | ||
} | ||
return shouldClear; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dismantled this method.
dirty
is now set in initDimensions
_forceClearCache
is reset in _clearCache
makes a lot more sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
So with the set part, we missed text changes that aren't coming from set. |
I want to share my reasoning.
If flagging Furthermore, if So this is a bigger fix, a scoping fix, part of making text scoped and organized. |
Going to solve conflicts and mere this tomorrow. |
Motivation
Description
_shouldClearDimensionCache
was changed in #8663, not taking into account state changes any longer including changes totext
which should trigger a layout -text
was changed but layout was skippedThis PR moderates those calls
Changes
Gist
In Action