chore(): safeguard extraParam in initialization

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [next]
 
+- chore(): safeguard `extraParam` in initialization [#8296](https://github.com/fabricjs/fabric.js/pull/8296)
 - chore(TS): polish text [#8489](https://github.com/fabricjs/fabric.js/pull/8489)
 - chore(TS): fix import cycle, extract `groupSVGElements` [#8506](https://github.com/fabricjs/fabric.js/pull/8506)
 - chore(TS): permissive `Point` typings [#8434](https://github.com/fabricjs/fabric.js/pull/8434)

src/shapes/polyline.class.ts

@@ -95,7 +95,10 @@ export class Polyline extends FabricObject {
    *   top: 100
    * });
    */
-  constructor(points: IPoint[] = [], { left, top, ...options }: any = {}) {
+  constructor(
+    points: IPoint[] = [],
+    { points: _, left, top, ...options }: any = {}
+  ) {
     super({ points, ...options });
     this.initialized = true;
     this.setBoundingBox(true);

test/unit/line.js

@@ -60,6 +60,9 @@
     assert.equal(lineWithoutPoints.get('y1'), 0);
     assert.equal(lineWithoutPoints.get('x2'), 0);
     assert.equal(lineWithoutPoints.get('y2'), 0);
+
+    const safeguradedLine = new fabric.Line(undefined, { x1: 1 });
+    assert.equal(safeguradedLine.get('x1'), 0, 'points should be safeguraded');
   });
 
   QUnit.test('complexity', function(assert) {

test/unit/path.js

@@ -93,10 +93,11 @@
 
   QUnit.test('initialize', function(assert) {
     var done = assert.async();
-    var path = new fabric.Path('M 100 100 L 200 100 L 170 200 z', { top: 0, strokeWidth: 0 });
+    var path = new fabric.Path('M 100 100 L 200 100 L 170 200 z', { top: 0, strokeWidth: 0, path: 'M 0 0' });
 
     assert.equal(path.left, 100);
     assert.equal(path.top, 0);
+    assert.deepEqual(path.path, fabric.util.parsePath('M 100 100 L 200 100 L 170 200 z'), 'path arg should be safeguraded');
     done();
   });
 

test/unit/polyline.js

@@ -62,6 +62,8 @@
 
     assert.equal(polyline.type, 'polyline');
     assert.deepEqual(polyline.get('points'), [{ x: 10, y: 12 }, { x: 20, y: 22 }]);
+
+    assert.deepEqual(new fabric.Polyline(getPoints(), { points: [] }).points, getPoints(), 'points arg should be safeguraded');
   });
 
   QUnit.test('complexity', function(assert) {

test/unit/text.js

@@ -77,6 +77,8 @@
 
     assert.equal(text.get('type'), 'text');
     assert.equal(text.get('text'), 'x');
+
+    assert.ok(new fabric.Text('a', { text: 'b' }).text, 'a', 'text arg should be safeguraded');
   });
 
   QUnit.test('toString', function(assert) {