chore(TS): more conversion of utils #8148

asturur · 2022-08-15T22:48:04Z

Convert a bit more of utils, and do ad hoc replacemente when the build break.

asturur · 2022-08-15T22:50:07Z

src/util/misc/matrix.ts

+    t[0] * p.x + t[2] * p.y + t[4],
+    t[1] * p.x + t[3] * p.y + t[5]
+  );
+};


Probably a point.tansform is a good idea too.

github-actions · 2022-08-15T23:15:14Z

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.51 |   84.39 |   80.65 |                                               
 fabric.js |   82.05 |    74.51 |   84.39 |   80.65 | ...,27444,27502,27512-27556,27664,27751,27955 
-----------|---------|----------|---------|---------|-----------------------------------------------

ShaMan123

should matrix be a class extending Array?
It makes sense IMO and will allow a drop replacement for matrix in the future
I will carefully merge stroke projection into #7475 when it is done

ShaMan123 · 2022-08-16T04:17:39Z

src/util/animate.ts

@@ -32,7 +32,7 @@ import { Point } from '../point.class';
   * @type {AnimationContext[]}
   */
  var fabric = global.fabric, RUNNING_ANIMATIONS = [];
-  fabric.util.object.extend(RUNNING_ANIMATIONS, {
+  extend(RUNNING_ANIMATIONS, {


IMO RUNNING_ANIMATIONS should be a subclass of Array

class AnimationRegistry extends Array<TAnimation> { ... } export const RUNNING_ANIMATIONS = new AnimationRegistry()

Doesn't have to be a subclass of array, it can be a class that has an array referenced. It doesn't really matter too much to me. Here i just swapped fabric.util.object because i had issues with circular imports, or at least i think i did.

even better

ShaMan123 · 2022-08-16T05:12:38Z

src/util/misc/matrix.ts

+  translateY?: number;
+}
+
+type TScaleMatrixArgs = {


type TScaleMatrixArgs = Patial<{ ... }>

https://www.typescriptlang.org/docs/handbook/utility-types.html

Why you prefer Partial here?

simply because all props are optional

ShaMan123 · 2022-08-16T05:14:51Z

src/util/misc/projectStroke.ts

+type projectStrokeOnPointsOptions = {
+  strokeWidth: number;
+  strokeLineJoin: StrokeLineJoin;
+  strokeMiterLimit: number; // https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-miterlimit


if the comment is /** **/ on top of the prop then it is live and not static text

and perhaps it should be a Pick type from TStrokeOptions or TObjectOptions

i ll recheck this, wasn't really a deep though.

ShaMan123 · 2022-08-16T14:24:27Z

src/util/misc/matrix.ts

+export const invertTransform = (t: TMat2D): TMat2D => {
+  const a = 1 / (t[0] * t[3] - t[1] * t[2]),
+        r = [a * t[3], -a * t[1], -a * t[2], a * t[0], 0, 0] as TMat2D,
+        { x, y } = transformPoint({ x: t[4], y: t[5] }, r, true);


we should decide about the fate of Point and IPoint

I side with your approach.
Everything should be a Point instance inside fabric

The reason why i didn't overuse the point years ago is because i thought a plain object would be more performant than a function or a class. But i think this is not true.
I never benchmarked it, and i struggle to understand why fabric starts to choke when cycling through an handful of hundreds objects.

I like that a Point can be a Point or its basic interface because it allows you to reuse the data you have without transforming it.

I think we need to aim for flexibility but tend to use Point in fabric and not a simple object.
I don't think there a real diff in perf.
All major repos use classes so it has to be a good idea and the browser as well

ShaMan123 · 2022-08-16T14:29:00Z

src/typedefs.ts

+  round = 'round',
+}
+
+export type TMat2D = [number, number, number, number, number, number];


maybe

export type TMat2D = [number, number, number, number] | [number, number, number, number, number, number];

i made this initially but then i had to go back because it makes more complicated to write code checking for 4 or 6 variant of the array.

github-actions · 2022-08-20T22:55:30Z

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.05 |    74.52 |    84.4 |   80.65 |                                               
 fabric.js |   82.05 |    74.52 |    84.4 |   80.65 | ...,27447,27505,27515-27559,27667,27754,27958 
-----------|---------|----------|---------|---------|-----------------------------------------------

asturur added 2 commits August 16, 2022 00:46

more utils

6ef8ec0

errors

e4a3c7d

asturur commented Aug 15, 2022

View reviewed changes

asturur added 2 commits August 16, 2022 00:57

no circ dep

44768a7

fix what i broke

cb9c965

ShaMan123 reviewed Aug 16, 2022

View reviewed changes

asturur added 2 commits August 21, 2022 00:41

small changes

f584919

more point creation

aaf9291

asturur merged commit 89f2299 into master Aug 21, 2022

asturur deleted the even-more-utils branch September 11, 2022 23:03

frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023

chore(TS): more conversion of utils (fabricjs#8148)

86bf322

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(TS): more conversion of utils #8148

chore(TS): more conversion of utils #8148

asturur commented Aug 15, 2022 •

edited

Loading

asturur Aug 15, 2022

ShaMan123 Aug 16, 2022

github-actions bot commented Aug 15, 2022 •

edited

Loading

ShaMan123 left a comment

ShaMan123 Aug 16, 2022

asturur Aug 16, 2022 •

edited

Loading

ShaMan123 Aug 16, 2022

ShaMan123 Aug 16, 2022 •

edited

Loading

asturur Aug 16, 2022

ShaMan123 Aug 16, 2022

ShaMan123 Aug 16, 2022

ShaMan123 Aug 16, 2022 •

edited

Loading

asturur Aug 16, 2022

ShaMan123 Aug 16, 2022

ShaMan123 Aug 16, 2022

asturur Aug 20, 2022 •

edited

Loading

ShaMan123 Aug 21, 2022

ShaMan123 Aug 16, 2022

asturur Aug 20, 2022

github-actions bot commented Aug 20, 2022 •

edited

Loading

chore(TS): more conversion of utils #8148

chore(TS): more conversion of utils #8148

Conversation

asturur commented Aug 15, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 15, 2022 • edited Loading

Code Coverage Summary

ShaMan123 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asturur Aug 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShaMan123 Aug 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShaMan123 Aug 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asturur Aug 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 20, 2022 • edited Loading

Code Coverage Summary

asturur commented Aug 15, 2022 •

edited

Loading

github-actions bot commented Aug 15, 2022 •

edited

Loading

asturur Aug 16, 2022 •

edited

Loading

ShaMan123 Aug 16, 2022 •

edited

Loading

ShaMan123 Aug 16, 2022 •

edited

Loading

asturur Aug 20, 2022 •

edited

Loading

github-actions bot commented Aug 20, 2022 •

edited

Loading