-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(freedrawing): test enhancement #7941
Conversation
What about the failing test? |
oh i assumed the failing test was firefox as usual |
Is the broken test a new test? |
The website visual test got broken, probably the qunit update. |
The test was built in node. It is a new test. It's the upper canvas test. |
We can fix the the display in browser, take the golden from there, and disable the node test once we understand how much the difference is. With shadow and opacity is mostly normal |
I have just updated ruby so I can't serve the website as well. |
Code Coverage Summary
|
Code Coverage Summary
|
Code Coverage Summary
|
If I understand correctly node canvas doesn't apply opacity to the shadow... |
we can take the browser one that is most common case ( especially for free drawing ) and we can disable the test when we detect node with fabric.isLikelyNode and move forward. |
When hiding passed tests is still broken, anyway, there are 22 failing tests in 5.2.0 mostly on svg import, i wonder what happened |
Code Coverage Summary
|
All set |
I forget about the json... |
This PR is a byproduct of the next PR that will add erasing visual tests.
I added logic to freedrawing tests to prepare for testing erasing and decided (with your voice guiding me :)) to split up the PR into dedicated changes.
This PR adds another layer of tests to free drawing by testing visuals before and after mouseup and comparing between them.
I think it's relevant and to the point.
It is proven by the tests failing (freedrawing4 -
Simple free drawing, with opacity
) -you might want to output the mesh result to a different file to compare changes. It might be desirable in general so tell me if to commit a different golden name for the mesh test.Shadow + opacity cause this it seems