refactor(object_interactivity): draw borders

[ShaMan123]

This PR refactors logic to enable easier overriding + maintenance.

• exposes private _drawBorders
• exposes public strokeBorders for easier overriding

BREAKING d257c99:

• removed drawBordersInGroup
• changed drawBroders signature

[github-actions]

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.03 |    75.97 |    85.7 |   82.75 |                                               
 fabric.js |   83.03 |    75.97 |    85.7 |   82.75 | ...,30832,30906,30917-30982,31105,31204,31440 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.02 |    75.94 |    85.7 |   82.74 |                                               
 fabric.js |   83.02 |    75.94 |    85.7 |   82.74 | ...,30832,30906,30917-30982,31105,31204,31440 
-----------|---------|----------|---------|---------|-----------------------------------------------

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[asturur]

we could say that this function is here exactly for the scope of overriding. Otherwise someone could argue, why having a method on a class that does not need this at all.
I would just say override this function in order to draw a different control box. example: rounded corners, different border style.
We should also inform whihc is the state of the context in that situation to give the dev some extra information.
(rotated aligned with object base, centered on the center of the object, scaled to absorb object scale and container scale and zoom )

[ShaMan123]

The ctx is in the same state as in the object's render method right?

[ShaMan123]

Or maybe not. I am confused

[ShaMan123]

(rotated aligned with object base, centered on the center of the object, scaled to absorb object scale and container scale and zoom )

hard to understand

[asturur]

the ctx is not in the same state, because when you scale the object the controls do not grow.
i m also wrong the ctx is only centered and rotated, and is not scaled at all.

I m pointing out that override in case of necessity can be writte on top of any function or none.
Since you made this refactor with a keen eye on having it overridable for some reason, just indicate the reason as an example for future reader

[ShaMan123]

If I recall correctly it is rotated and translated to center. But not scaled or skewed...

[ShaMan123]

36b7608

[github-actions]

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.12 |    76.04 |   85.77 |   82.85 |                                               
 fabric.js |   83.12 |    76.04 |   85.77 |   82.85 | ...,30832,30906,30917-30982,31105,31204,31440 
-----------|---------|----------|---------|---------|-----------------------------------------------

[github-actions]

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.13 |    76.07 |   85.77 |   82.86 |                                               
 fabric.js |   83.13 |    76.07 |   85.77 |   82.86 | ...,30832,30906,30917-30982,31105,31204,31440 
-----------|---------|----------|---------|---------|-----------------------------------------------

[ShaMan123]

READY