Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cacheContext checks #7694

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Conversation

andrejslogins
Copy link
Contributor

@andrejslogins andrejslogins commented Feb 17, 2022

Relates to #7693

Errors get thrown about
null is not an object (evaluating 'this._cacheContext.translate')
null is not an object (evaluating 'this._cacheContext.setTransform')

Added multiple checks for cacheContext cacheContext, should fix the issues occuring

@asturur
Copy link
Member

asturur commented Feb 18, 2022

Thank you!

@asturur asturur merged commit 3312ded into fabricjs:master Feb 18, 2022
@andrejslogins andrejslogins deleted the cache-context-undefined branch February 19, 2022 12:17
asturur pushed a commit that referenced this pull request Feb 21, 2022
… cache (#7694)

* Add cacheContext checks
* Set cacheContext to null when cacheCanvas gets removed
* call create cache canvas if cache context is undefined
@asturur asturur mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants