Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fabric.Canvas): fire an extra mouse up for the original control of the initial target #7612

Merged
merged 4 commits into from
Jan 15, 2022
Merged

feat(fabric.Canvas): fire an extra mouse up for the original control of the initial target #7612

merged 4 commits into from
Jan 15, 2022

Conversation

asturur
Copy link
Member

@asturur asturur commented Jan 15, 2022

close #7452

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2022 •
edited
Loading

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.4 |    77.22 |   86.16 |   83.12 |                                               
 fabric.js |    83.4 |    77.22 |   86.16 |   83.12 | ...,30182,30307,30387-30452,30575,30674,30891 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2022 •
edited
Loading

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.4 |    77.22 |   86.16 |   83.12 |                                               
 fabric.js |    83.4 |    77.22 |   86.16 |   83.12 | ...,30182,30307,30387-30452,30575,30674,30891 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2022 •
edited
Loading

Code Coverage Summary

> [email protected] coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    83.4 |    77.22 |   86.16 |   83.12 |                                               
 fabric.js |    83.4 |    77.22 |   86.16 |   83.12 | ...,30183,30308,30388-30453,30576,30675,30892 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit 91f0940 into master Jan 15, 2022
@asturur asturur mentioned this pull request Jan 26, 2022
Merged
rockerBOO pushed a commit to rockerBOO/fabric.js that referenced this pull request Jan 28, 2022
@asturur @rockerBOO
feat(fabric.Canvas): fire an extra mouse up for the original control …
5615237 
…of the initial target (fabricjs#7612)
@asturur asturur deleted the add-extra-mouseup branch February 4, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Control objects do no receive mouseup correctly
1 participant
@asturur