fix(fabric.text) fix rtl/ltr performance issues #7610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7435
As pointed out by @SLKnutson we are spamming calls of canvas.setAttribute('dir') and this causes the browser to do extra work.
We put the calls in the render cycle because we want to support mixed bidirectional test, but for now no one is working on them.
Brought the attribute at top level in the render cycle, inside the stack save, and it gets changed only if needed.
I could it bring it higher up but this restores the performances enough, and anyway the final destination is to handle this on a per style chunk basis.
Before code changes
after code changes