Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fabric.Group) realizeTransfrom should be working when called with NO parent transform #7413

Merged
merged 2 commits into from
Oct 3, 2021
Merged

fix(fabric.Group) realizeTransfrom should be working when called with NO parent transform #7413

merged 2 commits into from
Oct 3, 2021

Conversation

asturur
Copy link
Member

@asturur asturur commented Oct 3, 2021 •
edited
Loading

This bring the method back to pre 4.4.0 compatibility.
Sorry for the inconvenience.

close #7033
close #7391

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2021 •
edited
Loading

Code Coverage Summary

> [email protected] coverage:report /home/runner/work/fabric.js/fabric.js
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.31 |    77.05 |   86.12 |   83.02 |                                               
 fabric.js |   83.31 |    77.05 |   86.12 |   83.02 | ...,29992,30117,30197-30262,30385,30484,30701 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2021 •
edited
Loading

Code Coverage Summary

> [email protected] coverage:report /home/runner/work/fabric.js/fabric.js
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.31 |    77.04 |   86.12 |   83.02 |                                               
 fabric.js |   83.31 |    77.04 |   86.12 |   83.02 | ...,29993,30118,30198-30263,30386,30485,30702 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit a70e0f8 into master Oct 3, 2021
@asturur asturur deleted the fix-breaking-change branch January 9, 2022 11:29
@asturur asturur mentioned this pull request Jan 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strokeUniform not working on text Version 4.4.0 has a breaking API Change
1 participant
@asturur