feat(Observable): once event handler #7317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
reviewed
Aug 23, 2021
| function _once(eventName, handler) { | ||
| var _handler = function () { | ||
| handler(); | ||
| this.off(eventName, _handler); |
There was a problem hiding this comment.
I wonder how this work with hoisting.
We are referencing the function before we finish create it.
Is not a question about your code but more on javascript.
There was a problem hiding this comment.
I use it in my code....
What other option is there?
|
This is good. |
asturur
previously approved these changes
Aug 23, 2021
asturur
reviewed
Aug 23, 2021
|
i ll fix the semicolon and merge |
asturur
approved these changes
Aug 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very useful and saves repetitive
onofflogic for calling an event once and it alignsObservablewith node'sEventEmitter