-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pathSide property to text on path #7259
Conversation
Code Coverage Summary
|
Code Coverage Summary
|
src/shapes/text.class.js
Outdated
* @type {String} 'left|right' | ||
* @default | ||
*/ | ||
side: 'left', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the previous discussion, should we call this pathSide
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good. I think let's change startOffset
to pathStartOffset
as well for the same reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes i agree is fresh enough that no one noticed it yet.
Code Coverage Summary
|
i'm merging. |
Here's my newest implementation of the
side
property for text on a path. Note that I've used the nameside
to be consistent with the related SVG property, although SVGside
is currently supported only in Firefox.Feel free to test:
https://jsfiddle.net/melchiar/oLq91r2t/