fix(fabric.util): iterator step could`t be 0.01 #7233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sigh... Floating point errors. 😞 Nice find. |
|
@meetwhere-dev this is ok, but can you remove the built dist file? |
…til-pathIterator-bug
…2 = 0.0000...00034)" This reverts commit e810e3a.
oh Sorry about that. |
|
Sorry you have to fix tests too, because the tests are based on the old weird values |
|
Do you know how to run tests? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
i will fix tests in a following pr to correctly credit @meetwhere-dev |
|
before: after: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ex: 0.1 + 0.2 = 0.0000...00034
it will loss last one step when cal Path`s totalLength.