-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fabric.util): iterator step could`t be 0.01 #7233
Conversation
Sigh... Floating point errors. 😞 Nice find. |
@meetwhere-dev this is ok, but can you remove the built dist file? |
…til-pathIterator-bug
…2 = 0.0000...00034)" This reverts commit e810e3a.
oh Sorry about that. |
Sorry you have to fix tests too, because the tests are based on the old weird values |
Do you know how to run tests? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
i will fix tests in a following pr to correctly credit @meetwhere-dev |
before:
after:
|
ex: 0.1 + 0.2 = 0.0000...00034
it will loss last one step when cal Path`s totalLength.