Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't export objects/clipPath marked excludeFromExport #7148

Merged
merged 8 commits into from
Jun 26, 2021
Merged

fix: don't export objects/clipPath marked excludeFromExport #7148

merged 8 commits into from
Jun 26, 2021

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Jun 22, 2021 •
edited
Loading

Group should not export objects that are marked as excluded.
Group should not export clipPath if marked as excluded.
This PR aligns excludeFromExport behavior with Canvas.

@ShaMan123
fix:(Group): excludeFromExport on objects
da2a3b9 
Group should not export objects that are marked as excluded.
@ShaMan123 ShaMan123 changed the title fix(Group): excludeFromExport on objects fix(Group): don't export objects marked excludeFromExport Jun 22, 2021
@ShaMan123 ShaMan123 changed the title fix(Group): don't export objects marked excludeFromExport fix: don't export objects/clipPath marked excludeFromExport Jun 22, 2021
@asturur
Copy link
Member

asturur commented Jun 25, 2021

thank you this is good!

@asturur
Copy link
Member

asturur commented Jun 25, 2021

would you also add a line to the changelog, creating a version called next on top of the current 4.5.1?
So is easier to release later.

asturur
asturur previously approved these changes Jun 25, 2021
View reviewed changes
@ShaMan123
Copy link
Contributor Author

ShaMan123 commented Jun 26, 2021 •
edited
Loading

[4.5.1@next]

  • fix(fabric.EraserBrush): test eraser intersection with objects taking into account canvas viewport transform #7147
  • fix(fabric.Object): support excludeFromExport set on clipPath #7148.
  • fix(fabric.Group): support excludeFromExport set on a objects #7148.
  • fix(fabric.StaticCanvas): support excludeFromExport set on backgroundColor, overlayColor, clipPath #7148.

@asturur asturur merged commit 9a2e3ea into fabricjs:master Jun 26, 2021
@ShaMan123 ShaMan123 deleted the group-toObject-excludeFromExport branch June 26, 2021 18:04
@asturur asturur mentioned this pull request Aug 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaMan123 @asturur