Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Shadow): offsetX, offsetY and blur supports float #7019

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

proYang
Copy link
Contributor

@proYang proYang commented Apr 19, 2021

No description provided.

@proYang
Copy link
Contributor Author

proYang commented Apr 19, 2021

Before:

new fabric.Shadow('#FF0000 2.1px 2px 2px')

// blur: 0
// color: "#FF0000 2.1px"
// offsetX: 2
// offsetY: 2

Now:

new fabric.Shadow('#FF0000 2.1px 2px 2px')

// blur: 2
// color: "#FF0000"
// offsetX: 2.1
// offsetY: 2

OffsetX, offsetY and blur in fabric.Shadow did not support decimals. It's supported now.

@asturur
Copy link
Member

asturur commented Apr 20, 2021

Seems good to me. Thanks for the tests.
Would you go one step forward and also add a line to the changelog.md?

Add the tag NEXT on top, where usually the version is, and then add a line looking at the other changes for the format.

@proYang
Copy link
Contributor Author

proYang commented Apr 20, 2021

Seems good to me. Thanks for the tests.
Would you go one step forward and also add a line to the changelog.md?

Add the tag NEXT on top, where usually the version is, and then add a line looking at the other changes for the format.

Done!

@asturur asturur merged commit 172a721 into fabricjs:master Apr 20, 2021
@asturur asturur mentioned this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants