-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fabric.Group) make addWithUpdate compatible with nested groups #6774
Conversation
What is the issue so far: var rect = new fabric.Rect({fill: '#0c0', left: 0, top: 0, width: 30, height: 40});
var rect1 = new fabric.Rect({fill: '#c00', left: 30, top: 0, width: 60, height: 50});
window.group0 = new fabric.Group([rect, rect1], {left: 20, top: 30, originX: 'left', originY: 'top'});
var rect2 = new fabric.Rect({fill: '#ccc', left:40, top: 4, width: 30, height: 40});
var rect3 = new fabric.Rect({fill: '#00c', left: 80, top: 7, width: 60, height: 50});
window.group1 = new fabric.Group([rect2, rect3], {left: 40, top: 0, originX: 'left', originY: 'top'});
window.group = new fabric.Group([group0, group1], {left: 0, top: 30, originX: 'left', originY: 'top'});
canvas.add(group); Two triangles are added as a refence of position on the canvas We try to add the text to the grey/blue group. with the code: window.group1.addWithUpdate(canvas.getActiveObject())
canvas.renderAll() objects are grouped, but everything moved from its position. |
@jameszhong2008 seems we have a solution! |
@asturur Great job, hope this PR can be merged soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope this will be approve soon by reviewer who have write access
the pipeline from travis is stopped because we do not have credits anymore. Without pipeline i won't merge anything. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
bad bot. |
Code Coverage Summary
|
1 similar comment
Code Coverage Summary
|
Code Coverage Summary
|
Code Coverage Summary
|
Code Coverage Summary
|
The pr does not work great yet, needs some understanding of what is not going right.
close #6738