Updates to documentation #6726
Merged
Updates to documentation #6726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
commented
Dec 12, 2020
| * If you need to get a real Jpeg or Png from an object, using toDataURL is the right way to do it. | ||
| * toCanvasElement and then toBlob from the obtained canvas is also a good option. | ||
| * This method is sync now, but still support the callback because we did not want to break. | ||
| * When fabricJS 5.0 will be planned, this will probably be changed to not have a callback. |
There was a problem hiding this comment.
@GillesVermeulen for cloneAsImage
asturur
commented
Dec 12, 2020
| - Opera 9.64+ | ||
| - Chrome (all versions) | ||
| - IE10, IE11, Edge | ||
| - Edge (chromium based, all versions) | ||
| - IE11 and Edge legacy, supported but deprecated. |
There was a problem hiding this comment.
@jinwoo-kim-nhn clarified ie10 isn't supported anymore since 4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix numerous reported docs issues.
close Arguments are incorrectly documented for mouseDownHandler in custom control point #6682
close Setting "quality" when performing "cloneAsImage" has no effect #6678
close [Documentation] Canvas.toJSON reported as returning string, actually returns object #6697
close reflected in 4.2.0 is not reflected build file #6708