fix(text): incorrect cursor/selection position when text in group #6256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There has a incorrect position issue when render the cursor/selection in group.
asturur
reviewed
Apr 11, 2020
|
@jhondge any chance to fix the comment? Do you agree with it? |
yeah, of course. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@jhondge any chance to follow up on the pr? |
jhondge
commented
Jun 28, 2020
|
thank you! |
Merged
shanicerae
pushed a commit
to shanicerae/fabric.js
that referenced
this pull request
Jan 16, 2021
…in group (custom feature) (fabricjs#6256)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has a incorrect position issue when render the cursor/selection in group.