ISSUE-4115 - triggers in/out events for sub targets #6013

jakedowns · 2019-12-03T17:49:13Z

and calls _setCursorFromEvent for sub targets

…ls _setCursorFromEvent for sub targets pass linting

jakedowns · 2019-12-03T18:03:34Z

Shout-out to #4115 Here's a little preview of this PR in action to get you excited! :D

jakedowns · 2019-12-04T06:36:33Z

@asturur I am noticing something weird with this implementation, when I scroll (via canvas.viewportTransform[5]) the hover Over seems to work ok, but the hover Out isn't

I'll try to put together a reduced test case scenario tomorrow.

https://share.getcloudapp.com/o0uQylBp

…d draggedoverTargets tracking

asturur · 2019-12-06T07:52:45Z

i need some time to read it carefully.

asturur · 2019-12-06T07:54:52Z

i need some time to read it carefully.
You wrote lot of code, 0 comments. :)
takes time to review.

Try to explain what is the approach you took, there are difficulties in handling hover and out, on a stack of objects.

I'm happy to help you trough this and merge it, as long as you are ok accepting that is a mid long process of understanding and refining.

jakedowns · 2019-12-07T17:38:20Z

Oh yes, I totally understand. Thanks for being receptive & responsive to this PR.

My initial approach followed your original suggestion to the letter, I simply added a targetName argument, and used the key of the .targets[] array for naming, and tracking ._hoveredTargetN

however, this didn't seem sufficient, as, I'd roll across from one subtarget to the next, and sometimes, depending on the nesting, ._hoveredTarget0 would match (signaling an "oldTarget") but, really, there was a new ._hoveredTarget0 trying to be set. So it would sort of do an outFire & overFire, leading to it sometimes working, sometimes not, as it would get false-positives for "targetChanged"

My second attempt was to switch from a list of targets, keyed by their target array index to a dictionary keyed by a guid.

i added a pseudo-private .__guid getter to the base Object class (similar to the .__uid property already present)
canvas.hoveredTarget|N becomes => canvas._hoveredTargets = {}
- i also added canvas._hoveredTargetsOrdered = [string_guid1, string_guid2] in case a developer needed to reference the exact stacking order of the hovered objects, but maybe that was overkill.
I updated fireSyntheticInOutEvents to accept an array of Objects as it's first targets argument
Since _fireEnterLeaveEvents also uses fireSyntheticInOutEvents, i modified it to match, using targets instead of target and adding a corresponding canvas._draggedoverTargets<dictionary>, canvas._draggedoverTargetsOrdered<array>
I did my best to null out / delete lingering Object references in these two new places to avoid memory leaks as you suggested
I updated all the related tests I could find, but I have not yet added any new tests for checking that triggering in/out events for sub targets works as expected😳

asturur · 2019-12-08T12:29:31Z

So i have some requests:
I would leave the _hoveredTargetsOrdered out for this PR.
Let's implement the basic functionality first and test it.

I would also like to avoid to introduce the getter for the _guid.
I do not like the concept that _guid is related to graphical interfaces ( maybe i m wrong? ). I would like to understand if we can relate to the group structure to find the objects rather than adding an identifier for this.

asturur · 2019-12-08T13:12:58Z

I would image somehow the group structure is enough.
The targets we find and we put in the targets array should change only when some target change.
At that point every item in the target array from the change on is no more hovered, and all the one before the changed one are still hovered.

I would like to see this boiled down to the minimum amount of changes we need to support the basic feature.

jakedowns · 2019-12-09T17:13:27Z

Totally understand. Ok, I'll revert back to my first pass at implementing this and squash it into this PR

…rgets and draggedoverTargets tracking" This reverts commit b6fa464. # Conflicts: # src/mixins/canvas_events.mixin.js

# Conflicts: # src/mixins/canvas_events.mixin.js

src/canvas.class.js

asturur · 2019-12-14T09:42:32Z

Today i ll sit down and help with this.

asturur · 2019-12-14T21:19:33Z

i m actually on a local setup validating an idea. I will share asap

jakedowns · 2019-12-14T21:53:36Z

for what it’s worth. the simpler solution appears to be working on my branch. the only thing i’m having an issue with is once i pan/scroll using viewport transform as described in the official docs example, the hover no longer seems to work. i’m working on putting together a reduced test case on codepen

…

On Sat, Dec 14, 2019 at 1:19 PM Andrea Bogazzi ***@***.***> wrote: i m actually on a local setup validating an idea. I will share asap — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#6013?email_source=notifications&email_token=AAM25MRWUEAPEZ4CWUD6DLDQYVEWNA5CNFSM4JU4BENKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4LSYA#issuecomment-565754208>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAM25MU2E5CEMRSRMUGNZU3QYVEWNANCNFSM4JU4BENA> .

asturur · 2019-12-14T22:24:12Z

{"version":"3.5.1","objects":[{"type":"activeSelection","version":"3.5.1","left":-152,"top":656.25,"width":356.5,"height":356.5,"scaleX":0.45,"scaleY":0.45,"objects":[]},{"type":"group","version":"3.5.1","left":11,"top":6,"width":511.5,"height":511.5,"objects":[{"type":"rect","version":"3.5.1","left":-255.75,"top":-255.75,"width":50,"height":50,"fill":"#6ce798","scaleX":10.03,"scaleY":10.03,"opacity":0.8},{"type":"group","version":"3.5.1","left":-179.75,"top":22,"width":356.5,"height":356.5,"scaleX":0.54,"scaleY":0.54,"objects":[{"type":"rect","version":"3.5.1","left":-178.25,"top":-178.25,"width":50,"height":50,"fill":"#4862cc","scaleX":6.99,"scaleY":6.99,"opacity":0.8},{"type":"group","version":"3.5.1","left":-163.25,"top":-161.25,"width":177.5,"height":177.5,"objects":[{"type":"rect","version":"3.5.1","left":-88.75,"top":-88.75,"width":50,"height":50,"fill":"#5fe909","scaleX":3.48,"scaleY":3.48,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-59.75,"top":-68.75,"width":50,"height":50,"fill":"#f3529c","opacity":0.8},{"type":"triangle","version":"3.5.1","left":36.03,"top":-38.12,"width":50,"height":50,"fill":"#c1124e","angle":39.07,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-65.75,"top":17.25,"width":50,"height":50,"fill":"#9c5120","opacity":0.8}]},{"type":"group","version":"3.5.1","left":-34.25,"top":-31.25,"width":177.5,"height":177.5,"scaleX":1.08,"scaleY":1.08,"objects":[{"type":"rect","version":"3.5.1","left":-88.75,"top":-88.75,"width":50,"height":50,"fill":"#5fe909","scaleX":3.48,"scaleY":3.48,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-59.75,"top":-68.75,"width":50,"height":50,"fill":"#f3529c","opacity":0.8},{"type":"triangle","version":"3.5.1","left":36.03,"top":-38.12,"width":50,"height":50,"fill":"#c1124e","angle":39.07,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-65.75,"top":17.25,"width":50,"height":50,"fill":"#9c5120","opacity":0.8}]}]},{"type":"group","version":"3.5.1","left":-202.75,"top":-228.5,"width":356.5,"height":356.5,"scaleX":0.61,"scaleY":0.61,"objects":[{"type":"rect","version":"3.5.1","left":-178.25,"top":-178.25,"width":50,"height":50,"fill":"#4862cc","scaleX":6.99,"scaleY":6.99,"opacity":0.8},{"type":"group","version":"3.5.1","left":-163.25,"top":-161.25,"width":177.5,"height":177.5,"objects":[{"type":"rect","version":"3.5.1","left":-88.75,"top":-88.75,"width":50,"height":50,"fill":"#5fe909","scaleX":3.48,"scaleY":3.48,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-59.75,"top":-68.75,"width":50,"height":50,"fill":"#f3529c","opacity":0.8},{"type":"triangle","version":"3.5.1","left":36.03,"top":-38.12,"width":50,"height":50,"fill":"#c1124e","angle":39.07,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-65.75,"top":17.25,"width":50,"height":50,"fill":"#9c5120","opacity":0.8}]},{"type":"group","version":"3.5.1","left":-34.25,"top":-31.25,"width":177.5,"height":177.5,"scaleX":1.08,"scaleY":1.08,"objects":[{"type":"rect","version":"3.5.1","left":-88.75,"top":-88.75,"width":50,"height":50,"fill":"#5fe909","scaleX":3.48,"scaleY":3.48,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-59.75,"top":-68.75,"width":50,"height":50,"fill":"#f3529c","opacity":0.8},{"type":"triangle","version":"3.5.1","left":36.03,"top":-38.12,"width":50,"height":50,"fill":"#c1124e","angle":39.07,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-65.75,"top":17.25,"width":50,"height":50,"fill":"#9c5120","opacity":0.8}]}]},{"type":"group","version":"3.5.1","left":138.3,"top":-90.22,"width":356.5,"height":356.5,"scaleX":0.42,"scaleY":0.42,"angle":62.73,"objects":[{"type":"rect","version":"3.5.1","left":-178.25,"top":-178.25,"width":50,"height":50,"fill":"#4862cc","scaleX":6.99,"scaleY":6.99,"opacity":0.8},{"type":"group","version":"3.5.1","left":-163.25,"top":-161.25,"width":177.5,"height":177.5,"objects":[{"type":"rect","version":"3.5.1","left":-88.75,"top":-88.75,"width":50,"height":50,"fill":"#5fe909","scaleX":3.48,"scaleY":3.48,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-59.75,"top":-68.75,"width":50,"height":50,"fill":"#f3529c","opacity":0.8},{"type":"triangle","version":"3.5.1","left":36.03,"top":-38.12,"width":50,"height":50,"fill":"#c1124e","angle":39.07,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-65.75,"top":17.25,"width":50,"height":50,"fill":"#9c5120","opacity":0.8}]},{"type":"group","version":"3.5.1","left":-34.25,"top":-31.25,"width":177.5,"height":177.5,"scaleX":1.08,"scaleY":1.08,"objects":[{"type":"rect","version":"3.5.1","left":-88.75,"top":-88.75,"width":50,"height":50,"fill":"#5fe909","scaleX":3.48,"scaleY":3.48,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-59.75,"top":-68.75,"width":50,"height":50,"fill":"#f3529c","opacity":0.8},{"type":"triangle","version":"3.5.1","left":36.03,"top":-38.12,"width":50,"height":50,"fill":"#c1124e","angle":39.07,"opacity":0.8},{"type":"rect","version":"3.5.1","left":-65.75,"top":17.25,"width":50,"height":50,"fill":"#9c5120","opacity":0.8}]}]}]}]}

Storing here a json loadable nested group that is usefull for tests

asturur · 2019-12-14T22:49:03Z

@jakedowns i made #6032 a POC i did not even have time to run. I'm going to bed is midnight.
Please have a look at the idea, and think if it can work. I'm sure we can do something on those lines.

+ added a _this var for targets.forEach loop closure + changed targetName to oldTarget in _fireEnterLeaveEvents config object + added additional loop to call `fireSyntheticInOutEvents` when `this._hoveredTargets.length` is larger than `this.targets.length`

…out-sub-targets # Conflicts: # src/mixins/canvas_events.mixin.js

jakedowns · 2019-12-15T03:33:28Z

Thank you for your assistance with this. It's always great to have a second set of eyes looking at a problem to come up with the most elegant & straight-forward solution. Also great to have someone to bounce ideas back & forth with.

I've implemented the changes from your POC and your comments from your POC PR.
Thank you for allowing me to take ownership/credit for this PR as well! 🙇

Next step, I believe, is just a matter of making sure the unit tests account for these changes, correct? Any suggestions as to what you'd like to see in terms of test coverage?

I've tested on my local using the following setup and it appears to be working as expected:

https://gist.github.com/jakedowns/0fbca45fd8796e109e94635c2f221980

(^ you can ignore the zoom/pan bindings in there, I was trying to recreate the issue I have in my project repo where the hovering becomes mis-aligned after panning, but i believe it is a bug i'm somehow introducing somewhere else in my code, because sub-target hovering appears to work fine in this example, even when zoomed and/or panned. I'll have to narrow down that other bug some more before I can reproduce it in a simple test case, and so that I can ask for more assistance with it.)

+ reference new ._hoveredTargets array instead of Canvas._hoveredTargetN properties

src/canvas.class.js

src/mixins/canvas_events.mixin.js

src/shapes/object.class.js

src/mixins/canvas_events.mixin.js

asturur · 2019-12-15T17:58:42Z

I think we are nearly there, i would happy with even just a new test case using that json string and mocking up some event data. i can try to write one.

Thanks for being patient and collaborative.

jakedowns · 2019-12-15T21:15:55Z

@asturur Thanks again for all your help and attention with this PR. I stubbed in a new unit test:

7483142

~~Not sure of your preferred method of simulating the mouseMove events though. couldn't find an existing example of that.~~

I also adjusted _setCursorFromEvent to account for subTargets. I hope that's ok, my project relies on it, so i'm hoping it can be included when this finally releases. 1909d1f

src/mixins/canvas_events.mixin.js

test/unit/canvas_events.js

… single target

+ _fireOverOutEvents: fill diff array with nulls + _onMouseOut: remove debug console.log + updated description for subTargetCheck property to expand what it affects + updated subTargetCheck mouseover/mouseout event test case + added TODO notes for new tests for "mousemove: subTargetCheck: setCursorFromEvent considers subTargets"

asturur · 2019-12-18T12:07:59Z

I would proceed with a merge and then eventually fix if we broke anything. I can add more tests later.

jakedowns · 2019-12-18T16:25:41Z

let me know if there's anything else you need from me before proceeding with the merge :D

asturur · 2019-12-18T16:28:51Z

No, i want just to add more testing, but i realize we have not the infrastructure. Is easier for me to look at master than working on your branch, the build pass i think is fine.

asturur · 2019-12-18T16:31:51Z

src/mixins/canvas_events.mixin.js

+      var _this = this, _hoveredTarget = this._hoveredTarget,
+          _hoveredTargets = this._hoveredTargets, targets = this.targets,
+          diff = _hoveredTargets.length - targets.length;
+      [target].concat(targets, new Array(diff > 0 ? diff : 0).fill(null)).forEach(function(_target, index) {


@jakedowns sorry i did not notice this.
We still support internet explorer and fill is not an option there.

replaced with a for loop: dbaf781

test/unit/canvas_events.js

asturur · 2019-12-18T16:36:24Z

Yes i have seen the tests. Indeed i said more testing :) Il giorno mer 18 dic 2019 alle ore 17:34 Jake Downs < [email protected]> ha scritto:

…

***@***.**** commented on this pull request. ------------------------------ In test/unit/canvas_events.js <#6013 (comment)>: > + + // perform MouseOver event on a deeply nested subTarget + var moveEvent = fabric.document.createEvent('HTMLEvents'); + moveEvent.initEvent('mousemove', true, true); + var target = canvas.item(1); + canvas.targets = [ + target.item(1), + target.item(1).item(1), + target.item(1).item(1).item(1) + ]; + canvas._fireOverOutEvents(target, moveEvent); assert.equal(counterOver, 4, 'mouseover fabric event fired 4 times for primary hoveredTarget & subTargets'); - assert.equal(canvas._hoveredTarget, activeSelection, 'activeSelection is _hoveredTarget'); + assert.equal(canvas._hoveredTarget, target, 'activeSelection is _hoveredTarget'); assert.equal(canvas._hoveredTargets.length, 3, '3 additional subTargets are captured as _hoveredTargets'); + // perform MouseOut even on all hoveredTargets - assert.equal(counterOver, 4, 'mouseout fabric event fired 4 times for primary hoveredTarget & subTargets'); + canvas.targets = []; + canvas._fireOverOutEvents(null, moveEvent); + assert.equal(counterOut, 4, 'mouseout fabric event fired 4 times for primary hoveredTarget & subTargets'); assert.equal(canvas._hoveredTarget, null, '_hoveredTarget has been set to null'); assert.equal(canvas._hoveredTargets.length, 0, '_hoveredTargets array is empty'); }); }); + // TODO: QUnit.test('mousemove: subTargetCheck: setCursorFromEvent considers subTargets') + // TODO: QUnit.test('mousemove: subTargetCheck: setCursorFromEvent considers subTargets in reverse order, so the top-most subTarget's .hoverCursor takes precedence') + dunno if you saw this, but I did update this test so that it at least checks that the expected events fire for the subtargets — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6013?email_source=notifications&email_token=AAJDQQBETYGKBPFHLY5T4FDQZJGIHA5CNFSM4JU4BENKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPVALPY#pullrequestreview-334103999>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJDQQCUFUOUMEI2TLCZBNLQZJGIHANCNFSM4JU4BENA> .

asturur · 2019-12-18T17:48:12Z

src/mixins/canvas_events.mixin.js

+          diffArray = [];
+      for (var i = 0; i < diffArrayLength; i++){
+        diffArray.push(null);
+      }


oh i see, the array with 3 undefined will not iterate. Well ok this is fine, if will find away to have it more terse, it can be a follow up.

the length is 7 but forEach will not care

yeah forEach ignores the empties :/ interested to see what you come up with that's shorter than that. I looked at an Array.prototype.fill polyfill, but it was way more lines than a 3-line for loop.

asturur · 2019-12-18T20:36:50Z

to be honest we have a fabric.util.array.fill, but since i'm planning to remove those generic utils from the library ( non standard and out of scope ) i did not want to use it.
Probably there isn't a readable shorter version. Whatever i can think of makes the code unreadable for a couple of bytes of savings. not worth.

* Fixes fabricjs#4115 - triggers in/out events for sub targets; and calls _setCursorFromEvent for sub targets

Fixes fabricjs#4115 - triggers in/out events for sub targets; and cal…

54c5923

…ls _setCursorFromEvent for sub targets pass linting

jakedowns force-pushed the ISSUE-4115-mouse-over-out-sub-targets branch from ec0d03a to 54c5923 Compare December 3, 2019 17:56

added a .__guid property to each object to simplify hoveredTargets an…

b6fa464

…d draggedoverTargets tracking

jakedowns added 3 commits December 11, 2019 10:15

Revert "added a .__guid property to each object to simplify hoveredTa…

3c082a9

…rgets and draggedoverTargets tracking" This reverts commit b6fa464. # Conflicts: # src/mixins/canvas_events.mixin.js

Merge branch 'master' into ISSUE-4115-mouse-over-out-sub-targets

5fbf4a4

# Conflicts: # src/mixins/canvas_events.mixin.js

reverting hoveredTargets to bare bones implementation

15ab4ba

asturur reviewed Dec 14, 2019

View reviewed changes

src/canvas.class.js Outdated Show resolved Hide resolved

asturur added 2 commits December 14, 2019 23:43

this is an idea

38ae830

this is an idea

bc48c2d

jakedowns changed the title ~~Fixes #4115 - triggers in/out events for sub targets~~ ISSUE-4115 - triggers in/out events for sub targets Dec 15, 2019

Merge branch 'sub-targeting-mouse-in-out' into ISSUE-4115-mouse-over-…

69647aa

…out-sub-targets # Conflicts: # src/mixins/canvas_events.mixin.js

jakedowns added 2 commits December 14, 2019 19:46

adjust additional _hoveredTarget management

4ab6f2a

+ reference new ._hoveredTargets array instead of Canvas._hoveredTargetN properties

move _this to where it's needed

f24f61f

jakedowns commented Dec 15, 2019

View reviewed changes

src/canvas.class.js Outdated Show resolved Hide resolved

jakedowns commented Dec 15, 2019

View reviewed changes

src/canvas.class.js Show resolved Hide resolved

asturur reviewed Dec 15, 2019

View reviewed changes

src/mixins/canvas_events.mixin.js Outdated Show resolved Hide resolved

asturur reviewed Dec 15, 2019

View reviewed changes

src/shapes/object.class.js Outdated Show resolved Hide resolved

asturur reviewed Dec 15, 2019

View reviewed changes

src/mixins/canvas_events.mixin.js Outdated Show resolved Hide resolved

asturur reviewed Dec 15, 2019

View reviewed changes

src/mixins/canvas_events.mixin.js Outdated Show resolved Hide resolved

jakedowns added 6 commits December 15, 2019 12:19

correction to jsdoc array of fabric.Object type declaration

41978dd

remove genuine unique id GUID getter from object class

deb64f0

simplify & optimize for minification

426e68c

updated _fireEnterLeaveEvents to include subTargets

0cd4196

adjusted _setCursorFromEvent to account for subTargets

1909d1f

stub in unit test for fabricjs#4115

7483142

asturur reviewed Dec 16, 2019

View reviewed changes

src/mixins/canvas_events.mixin.js Outdated Show resolved Hide resolved

asturur reviewed Dec 16, 2019

View reviewed changes

test/unit/canvas_events.js Outdated Show resolved Hide resolved

jakedowns added 3 commits December 16, 2019 07:37

revert change in _onDragOver, call to _fireEnterLeaveEvents should be…

c4e53ce

… single target

rm unused var

3714348

asturur reviewed Dec 18, 2019

View reviewed changes

jakedowns commented Dec 18, 2019

View reviewed changes

test/unit/canvas_events.js Outdated Show resolved Hide resolved

jakedowns added 2 commits December 18, 2019 08:39

replace Array.fill with for loop (IE support)

dbaf781

update _fireEnterLeaveEvents to match _fireOverOutEvents

06e9c7e

asturur reviewed Dec 18, 2019

View reviewed changes

asturur merged commit f876769 into fabricjs:master Dec 18, 2019

asturur mentioned this pull request Dec 28, 2019

Version 3.6.0 #6056

Merged

ickata pushed a commit to ickata/fabric.js that referenced this pull request Jul 27, 2021

ISSUE-4115 - triggers in/out events for sub targets (fabricjs#6013)

7f3e5b6

* Fixes fabricjs#4115 - triggers in/out events for sub targets; and calls _setCursorFromEvent for sub targets

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ISSUE-4115 - triggers in/out events for sub targets #6013

ISSUE-4115 - triggers in/out events for sub targets #6013

jakedowns commented Dec 3, 2019

jakedowns commented Dec 3, 2019

jakedowns commented Dec 4, 2019

asturur commented Dec 6, 2019

asturur commented Dec 6, 2019

jakedowns commented Dec 7, 2019

asturur commented Dec 8, 2019

asturur commented Dec 8, 2019

jakedowns commented Dec 9, 2019

asturur commented Dec 14, 2019

asturur commented Dec 14, 2019

jakedowns commented Dec 14, 2019 via email

asturur commented Dec 14, 2019 •

edited

Loading

asturur commented Dec 14, 2019

jakedowns commented Dec 15, 2019 •

edited

Loading

asturur commented Dec 15, 2019

jakedowns commented Dec 15, 2019 •

edited

Loading

asturur commented Dec 18, 2019

jakedowns commented Dec 18, 2019

asturur commented Dec 18, 2019

asturur Dec 18, 2019

jakedowns Dec 18, 2019

asturur commented Dec 18, 2019 via email

asturur Dec 18, 2019

jakedowns Dec 18, 2019 •

edited

Loading

asturur commented Dec 18, 2019

ISSUE-4115 - triggers in/out events for sub targets #6013

ISSUE-4115 - triggers in/out events for sub targets #6013

Conversation

jakedowns commented Dec 3, 2019

jakedowns commented Dec 3, 2019

jakedowns commented Dec 4, 2019

asturur commented Dec 6, 2019

asturur commented Dec 6, 2019

jakedowns commented Dec 7, 2019

asturur commented Dec 8, 2019

asturur commented Dec 8, 2019

jakedowns commented Dec 9, 2019

asturur commented Dec 14, 2019

asturur commented Dec 14, 2019

jakedowns commented Dec 14, 2019 via email

asturur commented Dec 14, 2019 • edited Loading

asturur commented Dec 14, 2019

jakedowns commented Dec 15, 2019 • edited Loading

asturur commented Dec 15, 2019

jakedowns commented Dec 15, 2019 • edited Loading

asturur commented Dec 18, 2019

jakedowns commented Dec 18, 2019

asturur commented Dec 18, 2019

asturur Dec 18, 2019

Choose a reason for hiding this comment

jakedowns Dec 18, 2019

Choose a reason for hiding this comment

asturur commented Dec 18, 2019 via email

asturur Dec 18, 2019

Choose a reason for hiding this comment

jakedowns Dec 18, 2019 • edited Loading

Choose a reason for hiding this comment

asturur commented Dec 18, 2019

asturur commented Dec 14, 2019 •

edited

Loading

jakedowns commented Dec 15, 2019 •

edited

Loading

jakedowns commented Dec 15, 2019 •

edited

Loading

jakedowns Dec 18, 2019 •

edited

Loading