Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-4598 load from datalessJSON for svg groups is broken #5970

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

asturur
Copy link
Member

@asturur asturur commented Nov 15, 2019

close #4598
close #4560
close #5956
Original credit to @brentcappello

Reintroduce the sourcepath loading.
Be aware that this method is flawed at the root, and is not secure.
The SVG path will be used also if the dev will modify the internal structure of the group, in that case the reloading will just bring back the original SVG.

@asturur asturur changed the title add the fix ISSUE-4598 load from datalessJSON for svg groups is broken Nov 15, 2019
@asturur asturur merged commit 7d4f5b9 into master Nov 15, 2019
@asturur asturur mentioned this pull request Nov 18, 2019
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
@asturur asturur deleted the ISSUE-4598-loadfromdataless branch January 15, 2020 13:48
ickata pushed a commit to ickata/fabric.js that referenced this pull request Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant