Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invisibility of objects with no widht/height but strokewidth #5382

Merged
merged 3 commits into from
Nov 12, 2018

Conversation

asturur
Copy link
Member

@asturur asturur commented Nov 11, 2018

Our logic for skipping rendering was not taking in account the strokeWidth

close #5380

@asturur asturur changed the title Fix invisibilit of objects with no widht/height but strokewidth Fix invisibility of objects with no widht/height but strokewidth Nov 11, 2018
@asturur asturur merged commit cdb6b51 into master Nov 12, 2018
@asturur asturur mentioned this pull request Nov 25, 2018
@asturur asturur deleted the fix-invisible-lines branch December 10, 2018 23:55
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
…ricjs#5382)

* added test

* fixed ellipse test

* fixed ellipse lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG isn't rendered properly
1 participant