Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric update new canvas, new jsdom #5356

Merged
merged 27 commits into from
Mar 9, 2019
Merged

Fabric update new canvas, new jsdom #5356

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
c04da0e
change deps
asturur Oct 29, 2018
3f2d606
Update .travis.yml
asturur Oct 29, 2018
6f77498
some upadtes
asturur Mar 2, 2019
e370e57
some upadtes
asturur Mar 2, 2019
12b1e84
Merge branch 'master' into fabric-update-3.x
asturur Mar 2, 2019
2c57e20
sofar better than nothing
asturur Mar 2, 2019
bf5a7fe
sofar better than nothing
asturur Mar 2, 2019
f170d7c
ok a way forward
asturur Mar 2, 2019
e85d348
more improvements
asturur Mar 3, 2019
7182734
no dist built
asturur Mar 3, 2019
ad6c833
fixed visual tests
asturur Mar 3, 2019
1c713f6
fixed visual tests
asturur Mar 3, 2019
4a1f957
use 13.1 instead of 13.2
asturur Mar 3, 2019
5e61c06
fixed lint;
asturur Mar 3, 2019
1819981
removed one failure
asturur Mar 3, 2019
d8f1f15
some stuff run better
asturur Mar 3, 2019
fdbfb7a
less code
asturur Mar 3, 2019
4bdc2db
addedback text
asturur Mar 3, 2019
6a2a6a8
more tests
asturur Mar 3, 2019
da99f35
more tests
asturur Mar 3, 2019
7894e23
fixed lint
asturur Mar 3, 2019
ed404dc
isolate the requestRender change to visual tests
asturur Mar 3, 2019
c80bab1
disabled failing test
asturur Mar 3, 2019
775ef31
no failing test
asturur Mar 9, 2019
eab91b5
dependency updates
asturur Mar 9, 2019
644bb12
add node 11
asturur Mar 9, 2019
9e278f3
ignore nyc-output
asturur Mar 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ jobs:
node_js: "10"
- stage: Unit Tests
node_js: "8"
- stage: Unit Tests
node_js: "6"
- stage: Unit Tests
node_js: "4"
- stage: Unit Tests
env: CANVAS=canvas-prebuilt
node_js: "8"
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@
"testem:ci": "testem ci"
},
"optionalDependencies": {
"canvas": "^1.6.12",
"jsdom": "^9.12.0",
"canvas": "^2.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canvas 2.0 has some breaking changes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know i know, did not read yet how to interact with new jsdom. Canvas is transparent for us

"jsdom": "^13.0.0",
"xmldom": "0.1.x"
},
"devDependencies": {
Expand All @@ -75,7 +75,7 @@
"chalk": "^2.4.1"
},
"engines": {
"node": ">=4.0.0"
"node": ">=8.0.0"
},
"main": "./dist/fabric.js"
}