Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On shift select and multiselection, check for onSelect callback #5348

Merged
merged 3 commits into from
Oct 28, 2018
Merged

On shift select and multiselection, check for onSelect callback #5348

merged 3 commits into from
Oct 28, 2018

Conversation

asturur
Copy link
Member

@asturur asturur commented Oct 28, 2018

close #5317

@asturur asturur merged commit 8115d69 into master Oct 28, 2018
@asturur asturur mentioned this pull request Oct 28, 2018
Merged
@asturur asturur deleted the onSelect-and-multiselection branch October 29, 2018 20:57
@AlexSergey AlexSergey mentioned this pull request Nov 20, 2018
Closed
thiagocunha pushed a commit to thiagocunha/fabric.js that referenced this pull request Nov 18, 2019
@asturur
On shift select and multiselection, check for onSelect callback (fabr…
861dc29 
…icjs#5348)

* add onSelect on the grouping logic

* added test for group selector

* another test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unselectable objects can be selected with Shift+click
1 participant
@asturur