toSVG() excludeFromExport for backgroundImage and overlayImage #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore case for rgba
fabric.Color.reRGBa regex ignore case
ignore case for hsla
fabric.Color.reRGBa regex ignore case
added test case for RGB/RGBA and HSL/HSLA (uppercase)
test case RGBA / HSLA
|
The PR is ok. Do not worry about the commit list, just check that the tab |
|
Going to merge this, i just need to slim down the test |
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
excludeFromExportcheck for backgroundImage and overlayImage in toSVG(), all other objectsexcludeFromExport = trueworking fine.